From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <s.ivanov@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id EB8889720
for <pmg-devel@lists.proxmox.com>; Mon, 4 Sep 2023 15:43:25 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id CEA8FF6DB
for <pmg-devel@lists.proxmox.com>; Mon, 4 Sep 2023 15:43:25 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pmg-devel@lists.proxmox.com>; Mon, 4 Sep 2023 15:43:24 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AA104408BF
for <pmg-devel@lists.proxmox.com>; Mon, 4 Sep 2023 15:43:24 +0200 (CEST)
Date: Mon, 4 Sep 2023 15:43:23 +0200
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Message-ID: <20230904154323.1bf51d4e@rosa.proxmox.com>
In-Reply-To: <20230904115227.158138-1-m.sandoval@proxmox.com>
References: <20230904115227.158138-1-m.sandoval@proxmox.com>
X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.090 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pmg-devel] [PATCH pmg-api] fix #4944: api/pbs remote: Add a
port config
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
<pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>,
<mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>,
<mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 04 Sep 2023 13:43:26 -0000
Thanks for tackling this so quickly!
two tiny nits inline:
On Mon, 4 Sep 2023 13:52:27 +0200
Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:
> Allows to set a port via
>
> pmgbackup proxmox-backup remote set REMOTE --port PORT
you might mention that the client perl-module is shared with PVE, where
this is already possible/implemented
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> Tested both via
> - pmgbackup proxmox-backup backup REMOTE
> - webui
>
> src/PMG/PBSConfig.pm | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/PMG/PBSConfig.pm b/src/PMG/PBSConfig.pm
> index ee506f1..4431e43 100644
> --- a/src/PMG/PBSConfig.pm
> +++ b/src/PMG/PBSConfig.pm
> @@ -96,6 +96,11 @@ sub properties {
> type => 'string',
> optional => 1,
> },
> + port => {
> + description => "Proxmox Backup Server port.",
> + optional => 1,
> + type => 'integer',
> + },
you might want to add the additional information we already have in PVE:
https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage/PBSPlugin.pm;h=4320974b6b9c03c6ce4b722fb6b7d06550c7f359;hb=HEAD#l52
> username => get_standard_option('pmg-email-address', {
> description => "Username or API token ID on the Proxmox Backup Server"
> }),
> @@ -123,6 +128,7 @@ sub options {
> disable => { optional => 1 },
> username => { optional => 1 },
> password => { optional => 1 },
> + port => { optional => 1 },
> fingerprint => { optional => 1 },
> notify => { optional => 1 },
> 'include-statistics' => { optional => 1 },