From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <m.sandoval@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 1B7E8973C
 for <pmg-devel@lists.proxmox.com>; Mon,  4 Sep 2023 15:55:11 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id F0E2CF9B0
 for <pmg-devel@lists.proxmox.com>; Mon,  4 Sep 2023 15:54:40 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pmg-devel@lists.proxmox.com>; Mon,  4 Sep 2023 15:54:39 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 439B940914
 for <pmg-devel@lists.proxmox.com>; Mon,  4 Sep 2023 15:54:39 +0200 (CEST)
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pmg-devel@lists.proxmox.com
Date: Mon,  4 Sep 2023 15:54:37 +0200
Message-Id: <20230904135437.262664-1-m.sandoval@proxmox.com>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.004 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pmg-devel] [PATCH pmg-api v2] fix #4944: api/pbs remote: Add a
 port config
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
 <pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 04 Sep 2023 13:55:11 -0000

Allows to set a port via

    pmgbackup proxmox-backup remote set REMOTE --port PORT

The client perl-module is shared with Proxmox VE, where the required
bits for this to work are already implemented.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Differences from v1:
  - Added minimum, maximum, default values
  - Improved description
  - Added more info to the commit msg

 src/PMG/PBSConfig.pm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/PMG/PBSConfig.pm b/src/PMG/PBSConfig.pm
index ee506f1..998e960 100644
--- a/src/PMG/PBSConfig.pm
+++ b/src/PMG/PBSConfig.pm
@@ -96,6 +96,14 @@ sub properties {
 	    type => 'string',
 	    optional => 1,
 	},
+	port => {
+	    description => "Non-default port for Proxmox Backup Server.",
+	    optional => 1,
+	    type => 'integer',
+	    minimum => 1,
+	    maximum => 65535,
+	    default => 8007,
+	},
 	username => get_standard_option('pmg-email-address', {
 	    description => "Username or API token ID on the Proxmox Backup Server"
 	}),
@@ -123,6 +131,7 @@ sub options {
 	disable => { optional => 1 },
 	username => { optional => 1 },
 	password => { optional => 1 },
+	port => { optional => 1 },
 	fingerprint => { optional => 1 },
 	notify => { optional => 1 },
 	'include-statistics' => { optional => 1 },
-- 
2.39.2