From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D8898FB0D for ; Mon, 24 Jul 2023 13:06:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C156BD253 for ; Mon, 24 Jul 2023 13:06:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 24 Jul 2023 13:06:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0285D43ABA for ; Mon, 24 Jul 2023 13:06:37 +0200 (CEST) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Mon, 24 Jul 2023 13:06:24 +0200 Message-Id: <20230724110624.9502-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.094 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pmg-devel] [PATCH pmg-api] cluster: fingerprint parsing: adapt to changed openssl output X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jul 2023 11:06:38 -0000 currently updating the fingerprints using `pmgcm update-fingerprints` runs into an error indicating that parsing of the remote node's fingerprint fails The error is due to changed output in openssl's x509 command, introduced in commit: 91034b68b39e3525f09fb263b9272de410a3ba4c in openssl upstream [0] Note that in that case it would equally work to change the parameter from `-sha256` to `-SHA256` in the `openssl x509` command above The change seems small enough to warrant pulling it into stable-7 as well (although the issue should not occur in systems upgraded according to our howtos). [0] https://github.com/openssl/openssl/commit/91034b68b39e3525f09fb263b9272de410a3ba4c Reported-by: Martin Maurer Signed-off-by: Stoiko Ivanov --- quickly tested on a cluster of mine. src/PMG/Cluster.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PMG/Cluster.pm b/src/PMG/Cluster.pm index e9a6054..c431521 100644 --- a/src/PMG/Cluster.pm +++ b/src/PMG/Cluster.pm @@ -307,7 +307,7 @@ sub get_remote_cert_fingerprint { eval { PVE::Tools::run_command($ssh_cmd, outfunc => sub { my ($line) = @_; - if ($line =~ m/SHA256 Fingerprint=((?:[A-Fa-f0-9]{2}:){31}[A-Fa-f0-9]{2})/) { + if ($line =~ m/SHA256 Fingerprint=((?:[A-Fa-f0-9]{2}:){31}[A-Fa-f0-9]{2})/i) { $fp = $1; } }); -- 2.39.2