From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1124AC60E for ; Fri, 7 Jul 2023 18:54:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EA8332BB23 for ; Fri, 7 Jul 2023 18:54:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 7 Jul 2023 18:54:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 702C240D7F for ; Fri, 7 Jul 2023 18:54:40 +0200 (CEST) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Fri, 7 Jul 2023 18:54:26 +0200 Message-Id: <20230707165428.94777-3-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230707165428.94777-1-s.ivanov@proxmox.com> References: <20230707165428.94777-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.095 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pmg7to8.pm] Subject: [pmg-devel] [PATCH pmg-api 2/4] pmg7to8: notify about unmodified templates X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2023 16:54:42 -0000 I considered making this a warning, but since unmodified files get updated to the new versions in /var/lib/pmg/templates by ucf a notice seems more appropriate. Signed-off-by: Stoiko Ivanov --- src/PMG/CLI/pmg7to8.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/PMG/CLI/pmg7to8.pm b/src/PMG/CLI/pmg7to8.pm index ea29056..1cb4e7f 100644 --- a/src/PMG/CLI/pmg7to8.pm +++ b/src/PMG/CLI/pmg7to8.pm @@ -552,6 +552,12 @@ sub check_misc { check_apt_repos(); check_bootloader(); + + if (my $unmodified_templates = PMG::Utils::find_unmodified_templates()) { + my $msg = "Found templates in /etc/pmg/templates, without modification. Consider simply removing them: \n "; + $msg .= join("\n ", $unmodified_templates->@*); + log_notice($msg); + } } my sub colored_if { -- 2.39.2