From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 03F6FC60C for ; Fri, 7 Jul 2023 18:54:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D9B172BB22 for ; Fri, 7 Jul 2023 18:54:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 7 Jul 2023 18:54:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6C29940CE9 for ; Fri, 7 Jul 2023 18:54:40 +0200 (CEST) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Fri, 7 Jul 2023 18:54:24 +0200 Message-Id: <20230707165428.94777-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.095 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [utils.pm, report.pm, pmg7to8.pm] Subject: [pmg-devel] [PATCH pmg-api 0/4] add notification about unmodified template-overrides X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2023 16:54:42 -0000 This patch series adds functionality to notify users and our support about templates copied to /etc/pmg/templates, without any changes. While I thought initially that this could lead to actual issues (as the unmodified templates from an old version mask the changes we provide in the package) - this is luckily handled gracefully by ucf (which simply overwrites the unmodified version in /etc/pmg/templates, by the new one in /var/lib/pmg/templates.) The merit of the series is (at least) that it should now be easier to see actually relevant changes in the templates in our support-channels (through the updated report). if applied - it would make sense to also apply this to stable-7 Stoiko Ivanov (4): utils: add helper for unmodified templates pmg7to8: notify about unmodified templates report: skip irrelevant files in /etc/pmg/templates report: group use statements src/PMG/CLI/pmg7to8.pm | 6 ++++++ src/PMG/Report.pm | 28 ++++++++++++++++++++++++++-- src/PMG/Utils.pm | 20 ++++++++++++++++++++ 3 files changed, 52 insertions(+), 2 deletions(-) -- 2.39.2