From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C373CB9F7 for ; Mon, 3 Jul 2023 11:15:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A56FB1AABB for ; Mon, 3 Jul 2023 11:15:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 3 Jul 2023 11:15:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E35AB438C5 for ; Mon, 3 Jul 2023 11:15:49 +0200 (CEST) Date: Mon, 3 Jul 2023 11:15:48 +0200 From: Stoiko Ivanov To: Dominik Csapak Cc: pmg-devel@lists.proxmox.com Message-ID: <20230703111548.5c30a5f9@rosa.proxmox.com> In-Reply-To: <20230703082819.2383611-1-d.csapak@proxmox.com> References: <20230703082819.2383611-1-d.csapak@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.24; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.095 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pmg-devel] applied: [PATCH pmg-api] pmgsh: fix calling the api paths directly X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jul 2023 09:15:51 -0000 Thanks for the fix! Applied with bug-reference and Fixes trailer added! On Mon, 3 Jul 2023 10:28:19 +0200 Dominik Csapak wrote: > if we get a command directly, we don't initialize the $rpcenv > variable anymore. > > To fix it, make it a local variable of the pmg_command function. > We now make one extra '->get()' call per command (as opposed to > once per program), but that shouldn't cost us anything really. > > Reported in the forum: https://forum.proxmox.com/threads/pmgsh-failing.130008/ > > Signed-off-by: Dominik Csapak > --- > src/bin/pmgsh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/bin/pmgsh b/src/bin/pmgsh > index f9816cd..7499c42 100755 > --- a/src/bin/pmgsh > +++ b/src/bin/pmgsh > @@ -78,7 +78,6 @@ if (scalar (@ARGV) != 0) { > > # only set up once actually required allows calling verifyapi in restriced clean sbuild env > PMG::RESTEnvironment->setup_default_cli_env(); > -my $rpcenv = PMG::RESTEnvironment->get(); > initlog($ENV{PVE_LOG_ID} || 'pmgsh'); > > print "entering PMG shell - type 'help' for help\n"; > @@ -451,6 +450,7 @@ sub list_dir { > sub pmg_command { > my ($args, $nooutput) = @_; > > + my $rpcenv = PMG::RESTEnvironment->get(); > $rpcenv->init_request(); > > my $ticket = PMG::Ticket::assemble_ticket('root@pam');