From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8578E9D6F for ; Mon, 26 Jun 2023 22:45:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6E42C2D761 for ; Mon, 26 Jun 2023 22:45:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 26 Jun 2023 22:45:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B9BCA44B89 for ; Mon, 26 Jun 2023 22:45:15 +0200 (CEST) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Mon, 26 Jun 2023 22:45:09 +0200 Message-Id: <20230626204510.34783-2-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230626204510.34783-1-s.ivanov@proxmox.com> References: <20230626204510.34783-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.097 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pmg-devel] [PATCH pmg-api 1/2] cluster: fix rsync invocation X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2023 20:45:16 -0000 Since rsync 3.2.4, the syntax to give multiple files in one parameter does not work anymore, so list them explicitly Inspired by commit 9697997575e25e188a0993a0e4fc7f33f6602928 in pve-cluster Signed-off-by: Stoiko Ivanov --- src/PMG/Cluster.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/PMG/Cluster.pm b/src/PMG/Cluster.pm index 7622a88..e9a6054 100644 --- a/src/PMG/Cluster.pm +++ b/src/PMG/Cluster.pm @@ -418,7 +418,9 @@ sub sync_config_from_master { my $cmd = $rsync_command->( $master_name, '-aq', - "[${master_ip}]:$cfgdir/* ${sa_conf_dir}/${sa_custom_cf} ${sa_conf_dir}/${sa_rules_cf}", + "[${master_ip}]:$cfgdir/*", + "[${master_ip}]:${sa_conf_dir}/${sa_custom_cf}", + "[${master_ip}]:${sa_conf_dir}/${sa_rules_cf}", "$syncdir/", '--exclude', 'master/', '--exclude', '*~', -- 2.30.2