From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ED1739200B for ; Tue, 28 Mar 2023 11:34:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CFD141EFA2 for ; Tue, 28 Mar 2023 11:33:39 +0200 (CEST) Received: from sara.proxmox.com (unknown [94.136.29.99]) by firstgate.proxmox.com (Proxmox) with ESMTP for ; Tue, 28 Mar 2023 11:33:39 +0200 (CEST) Received: by sara.proxmox.com (Postfix, from userid 1000) id 5071F41BC6; Tue, 28 Mar 2023 11:33:39 +0200 (CEST) From: Moayad Almalat To: pmg-devel@lists.proxmox.com Date: Tue, 28 Mar 2023 11:33:11 +0200 Message-Id: <20230328093336.830181-1-m.almalat@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.233 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pmg-devel] [PATCH pmg-api] Registration: Restrict special characters in usernames when creating a new user X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2023 09:34:10 -0000 From: Moayad Almalat Signed-off-by: Moayad Almalat --- src/PMG/Utils.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PMG/Utils.pm b/src/PMG/Utils.pm index 6405934..41b47c7 100644 --- a/src/PMG/Utils.pm +++ b/src/PMG/Utils.pm @@ -92,7 +92,7 @@ sub verify_username { # slash is not allowed because it is used as pve API delimiter # also see "man useradd" my $realm_list = join('|', @$valid_pmg_realms); - if ($username =~ m!^([^\s:/]+)\@(${realm_list})$!) { + if ($username =~ m!^([A-Za-z0-9_\-.]+)\@(${realm_list})$!) { return wantarray ? ($username, $1, $2) : $username; } -- 2.30.2