From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9CC0E906FD for ; Fri, 24 Mar 2023 13:47:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 85813B6E6 for ; Fri, 24 Mar 2023 13:47:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 24 Mar 2023 13:47:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3AA5146883 for ; Fri, 24 Mar 2023 13:47:24 +0100 (CET) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Fri, 24 Mar 2023 13:46:52 +0100 Message-Id: <20230324124655.39567-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.858 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH spamassassin/pmg-api ] ship complete KAM ruleset X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2023 12:47:25 -0000 A few warnings were observed, when upgrading to proxmox-spamassassin 4.0 and to a pmg-api > 7.2-5: * the sa-rules we ship in proxmox-spamassassin still recorded SA version 3.4.6 and spamassassin warned about that - this is fixed independently, by pushing updates SA rules directly (after running our regression_tests) * the KAM.cf file as of recently depends on the other files in the complete ruleset as well: ``` WARNING: HashBL: PCCC_HASHBL_FREEMAIL acl 'freemail' not defined ``` This patchset addresses the latter issue by shipping the complete KAM ruleset with each proxmox-spamassassin package. The download using sa-update is based on the code in pmg-api, which does the same in pmg-daily I'm sending only the actual code and doc changes - and, if approved, would push the actual rule-update and removal directly instead of sending multiple megabytes of spamassassin rule definitions (which would not pass our mail-gateway anyways :) testing this is best done by applying the patches and running `make update-kam` With using kam_sa-channels_mcgrail_com.cf to include all files in the ruleset the adaptation of the local.cf template (pmg-api patch 1/1) would need a versioned dependeny bump on proxmox-spamassassin In my tests spamassassin (pmg-smtp-filter) quite happily ignored the missing /usr/share/spamassassin-extra/KAM.cf file - so a Breaks in the other direction should not be needed. proxmox-spamassassin: Stoiko Ivanov (2): kam-rules: ship full ruleset not only KAM.cf buildsys: update outdated docs on updating rulesets Makefile | 41 +++++++++++++++++------------------------ 1 file changed, 17 insertions(+), 24 deletions(-) pmg-api: Stoiko Ivanov (1): templates: adapt to new path for KAM rules in proxmox-spamassassin src/templates/local.cf.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.30.2