From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7C80992F51 for ; Thu, 23 Mar 2023 16:45:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C1F1C2ECF3 for ; Thu, 23 Mar 2023 16:45:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 23 Mar 2023 16:45:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 648AF4660D for ; Thu, 23 Mar 2023 16:44:59 +0100 (CET) From: Stefan Sterz To: pmg-devel@lists.proxmox.com Date: Thu, 23 Mar 2023 16:44:54 +0100 Message-Id: <20230323154455.1458701-3-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230323154455.1458701-1-s.sterz@proxmox.com> References: <20230323154455.1458701-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [sencha.com] Subject: [pmg-devel] [PATCH pmg-gui 2/3] quarantines: fix the default behavior of the theme toggle button X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2023 15:45:07 -0000 since the default theme is "auto" now, the behavior of the dark theme toggle needs to be adjust accordingly. Signed-off-by: Stefan Sterz --- checking for null here explicitly as that is the documented behavior if the cookie does not exist [1]. https://docs-devel.sencha.com/extjs/6.0.0/classic/Ext.util.Cookies.html#method-get js/controller/QuarantineController.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/controller/QuarantineController.js b/js/controller/QuarantineController.js index 15e69fa..3135e2b 100644 --- a/js/controller/QuarantineController.js +++ b/js/controller/QuarantineController.js @@ -194,7 +194,7 @@ Ext.define('PMG.controller.QuarantineController', { let me = this; let currentTheme = Ext.util.Cookies.get("PMGThemeCookie"); - if (currentTheme === "auto") { + if (currentTheme === "__default__" || currentTheme === null) { me.mediaQueryList = window.matchMedia("(prefers-color-scheme: dark)"); me.themeListener = (e) => { @@ -207,7 +207,7 @@ Ext.define('PMG.controller.QuarantineController', { me.themeListener(me.mediaQueryList); me.mediaQueryList.addEventListener("change", me.themeListener); - } else if (currentTheme === "__default__") { + } else if (currentTheme === "crisp") { me.hideThemeToggle(); } else { me.showThemeToggle(); -- 2.30.2