From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9417E9616B for ; Mon, 23 Jan 2023 16:56:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4771329DBF for ; Mon, 23 Jan 2023 16:55:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 23 Jan 2023 16:55:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0420045C8E for ; Mon, 23 Jan 2023 16:55:51 +0100 (CET) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Mon, 23 Jan 2023 16:55:20 +0100 Message-Id: <20230123155521.28307-2-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230123155521.28307-1-s.ivanov@proxmox.com> References: <20230123155521.28307-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.157 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to DNSWL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [utils.pm, postfix.org, proxmox.com] Subject: [pmg-devel] [PATCH pmg-api 1/2] utils: skip checking headers for non-ascii characters X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2023 15:56:22 -0000 the fix for smtputf8 enablement in 191e4709e99a5975fa66cf21847887566e108501 was a bit too eager and broke the mailflow of a few users, who have smtputf8 disabled in their postfix config (because their downstream servers do not support this): The issue here is that the mails they process have had (non-rfc-compliant) non-ascii header contents, which used to work before the patch. The postfix smtputf8 howto explains quite well that postfix never cared too much about headers (or local-parts of addresses) before smtputf8 [1] ``` Postfix already permitted UTF-8 in message header values and in address localparts. This does not change. ``` While the patch only ignores the headers and still could cause issues with non-ascii local-parts, those should occur far less frequently in the wild (none of the reporters in our forum had this). tested with a mail with an Euro sign in a 'X-From:' header. [0] https://forum.proxmox.com/threads/.120886/ [1] https://www.postfix.org/SMTPUTF8_README.html#enabling Signed-off-by: Stoiko Ivanov --- src/PMG/Utils.pm | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/PMG/Utils.pm b/src/PMG/Utils.pm index 825b8d9..9c6f841 100644 --- a/src/PMG/Utils.pm +++ b/src/PMG/Utils.pm @@ -232,10 +232,6 @@ sub mail_needs_smtputf8 { } } - if ($entity->head()->as_string() =~ /([^\p{PosixPrint}\n\r\t])/) { - return 1; - } - return 0; } -- 2.30.2