From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DDCD7C498 for ; Mon, 28 Nov 2022 19:18:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ABA6136FDD for ; Mon, 28 Nov 2022 19:17:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 28 Nov 2022 19:17:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A229844EFF for ; Mon, 28 Nov 2022 19:17:43 +0100 (CET) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Mon, 28 Nov 2022 19:17:27 +0100 Message-Id: <20221128181729.63076-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.164 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH pmg-api 0/2] fix deprecation warning for user blocklist hits X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Nov 2022 18:18:16 -0000 the 2 patches address quite different issues, both becoming visible when a mail is blocked/quarantined due to being on the receivers blocklist: * currently we use the description from SA for 'USER_IN_BLACKLIST', which includes since a while a deprecation warning (it's been replaced by USER_IN_BLOCKLIST, and afaict the old version will be dropped with SpamAssassin 4.0 soon). However PMG's SA rule only shares the name with the one from upstream SA (in the sense that our source of addresses is the database and not the SA-config), so we should make sure that the description is consistent * We should also rethink/adapt our use of racially charged terms (and try to be consistent with SpamAssassin upstream in our choices) - I plan on addressing this once SpamAssassin 4.0 is released (patch 2/2 is only a small part and only touches the user/admin visible parts for the user blocklists) For now the issue is a cosmetic one, and both approaches would address the spurious DEPRECATED in the spaminfo widget in the GUI (although patch 1/2 moves code around that 2/2 touches) Stoiko Ivanov (2): user-bl: use custom description of USER_IN_BLACKLIST consistently user accesslists: reword logging and hits for SA 4.0 src/PMG/RuleDB/Spam.pm | 10 +++++----- src/PMG/Utils.pm | 6 ++++++ 2 files changed, 11 insertions(+), 5 deletions(-) -- 2.30.2