From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 320F38D199 for ; Mon, 7 Nov 2022 13:19:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0F2902AC30 for ; Mon, 7 Nov 2022 13:19:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 7 Nov 2022 13:19:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 499BF42669 for ; Mon, 7 Nov 2022 13:19:07 +0100 (CET) From: Thomas Lamprecht To: pmg-devel@lists.proxmox.com Date: Mon, 7 Nov 2022 13:18:49 +0100 Message-Id: <20221107121849.1323453-1-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] applied: [PATCH] spam quarantine controller: fix args when calling the parent multiSelect X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2022 12:19:38 -0000 arguments needs to be an array, often we call with all of ours, iow. using `arguments` which itself is an array already. Both, manual construction and just a passing `arguments` have their advantage and disadvantage, e.g., if either the inheriting or bequesting class becomes more specialized, but most of the time using `arguments` is more future proof. Fixes: e66c888 ("quarantine: refactor spamquarantine controller") Signed-off-by: Thomas Lamprecht --- avoids an spurious undefined when selecting multiple emails. js/SpamQuarantine.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/SpamQuarantine.js b/js/SpamQuarantine.js index 388fc02..7487c8f 100644 --- a/js/SpamQuarantine.js +++ b/js/SpamQuarantine.js @@ -51,7 +51,7 @@ Ext.define('PMG.SpamQuarantineController', { spam.setDisabled(true); spam.setPressed(false); me.lookupReference('spaminfo').setVisible(false); - me.callParent(selection); + me.callParent(arguments); }, toggleSpamInfo: function(btn) { -- 2.30.2