From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6F0848CBF5 for ; Fri, 4 Nov 2022 16:04:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 539C4567A for ; Fri, 4 Nov 2022 16:04:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 4 Nov 2022 16:04:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7161D44D55 for ; Fri, 4 Nov 2022 16:04:26 +0100 (CET) From: Dominik Csapak To: pmg-devel@lists.proxmox.com Date: Fri, 4 Nov 2022 16:04:24 +0100 Message-Id: <20221104150425.124194-6-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221104150425.124194-1-d.csapak@proxmox.com> References: <20221104150425.124194-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.066 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH pmg-gui 4/5] quarantine: improve borders for docked items X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2022 15:04:29 -0000 one cannot set the different borders seperately in panels/grids and docked items don't have a bottom border in extjs, but we want to remove all borders except the ones between the toolbar and the grids/content below that. to achieve that, set a custom 'border-bottom-width' with '!important' (extjs has a rule with !important as well) for the toolbar, and everywhere else remove the border. Signed-off-by: Dominik Csapak --- js/SpamQuarantine.js | 8 +++++++- js/VirusQuarantine.js | 6 ++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/js/SpamQuarantine.js b/js/SpamQuarantine.js index d3afcc5..2cdca0d 100644 --- a/js/SpamQuarantine.js +++ b/js/SpamQuarantine.js @@ -204,6 +204,11 @@ Ext.define('PMG.SpamQuarantine', { { xtype: 'toolbar', dock: 'top', + style: { + // docked items have set the bottom with to 0px with '! important' + // but we still want one here, so we can remove the borders of the grids + 'border-bottom-width': '1px ! important', + }, items: [ { xtype: 'button', @@ -270,8 +275,8 @@ Ext.define('PMG.SpamQuarantine', { }, { xtype: 'pmgSpamInfoGrid', - border: false, reference: 'spaminfo', + border: false, }, { xtype: 'pmgAttachmentGrid', @@ -286,6 +291,7 @@ Ext.define('PMG.SpamQuarantine', { xtype: 'pmgMailInfo', hidden: true, reference: 'mailinfo', + border: false, }, ], }, diff --git a/js/VirusQuarantine.js b/js/VirusQuarantine.js index 8580e7a..a92ba28 100644 --- a/js/VirusQuarantine.js +++ b/js/VirusQuarantine.js @@ -106,6 +106,11 @@ Ext.define('PMG.VirusQuarantine', { { xtype: 'toolbar', dock: 'top', + style: { + // docked items have set the bottom with to 0px with '! important' + // but we still want one here, so we can remove the borders of the grids + 'border-bottom-width': '1px ! important', + }, items: [ { xtype: 'button', @@ -163,6 +168,7 @@ Ext.define('PMG.VirusQuarantine', { xtype: 'pmgMailInfo', hidden: true, reference: 'mailinfo', + border: false, }, ], }, -- 2.30.2