From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4DB8B8CC3F for ; Fri, 4 Nov 2022 16:04:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 34BC05642 for ; Fri, 4 Nov 2022 16:04:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 4 Nov 2022 16:04:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F00C844D5B for ; Fri, 4 Nov 2022 16:04:25 +0100 (CET) From: Dominik Csapak To: pmg-devel@lists.proxmox.com Date: Fri, 4 Nov 2022 16:04:23 +0100 Message-Id: <20221104150425.124194-5-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221104150425.124194-1-d.csapak@proxmox.com> References: <20221104150425.124194-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.066 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH pmg-gui 3/5] fix #4238: SpamInfoGrid: enable sorting & add colors for spam score X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2022 15:04:28 -0000 sorting the matching spam rules, e.g. by score, makes it easier to see which rules have more weight in determining spam. Additionally, color code the scores with colors akin to the rationale in commit: 365f84c ("quarantines: color code deliver and delete buttons") (red for positive spam scores, blue for negative ones) and increase the font-weight for large spamscore contributing rules. i chose a different blue tone that is more muted than what we use in 'info-blue' but is different from both the 'hover' color and the 'selected' color Signed-off-by: Dominik Csapak --- while the bug mentions that colors are problematic, there are not enough font-weights to properly convey what we want to show here, so i added colors with the same rationale we already used for the deliver/delete buttons js/SpamInfoGrid.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/js/SpamInfoGrid.js b/js/SpamInfoGrid.js index f7ee2b2..c9777d7 100644 --- a/js/SpamInfoGrid.js +++ b/js/SpamInfoGrid.js @@ -2,8 +2,6 @@ Ext.define('PMG.grid.SpamInfoGrid', { extend: 'Ext.grid.GridPanel', xtype: 'pmgSpamInfoGrid', - hideHeaders: true, - store: { autoDestroy: true, fields: ['desc', 'name', { type: 'number', name: 'score' }], @@ -45,6 +43,12 @@ Ext.define('PMG.grid.SpamInfoGrid', { text: gettext('Score'), dataIndex: 'score', align: 'right', + renderer: function(value, metaData) { + let color = value < 0 ? '#d7e9f6' : value > 0 ? '#f3d6d7' : ''; + let fontWeight = value >= 3 ? '1000' : value >= 1.5 ? '600' : ''; + metaData.tdStyle = `background-color: ${color}; font-weight: ${fontWeight};`; + return value; + }, summaryType: 'sum', summaryRenderer: function(value, summaryData, dataIndex, metaData) { return Ext.util.Format.round(value, 5); -- 2.30.2