From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A121E9249C for ; Tue, 4 Oct 2022 13:58:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 84C1934FA for ; Tue, 4 Oct 2022 13:58:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 4 Oct 2022 13:58:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 610EF447A1 for ; Tue, 4 Oct 2022 13:58:28 +0200 (CEST) Date: Tue, 4 Oct 2022 13:58:27 +0200 From: Stoiko Ivanov To: Dominik Csapak Cc: pmg-devel@lists.proxmox.com Message-ID: <20221004135827.00bb7e5b@rosa.proxmox.com> In-Reply-To: <20220701114200.2984712-1-d.csapak@proxmox.com> References: <20220701114200.2984712-1-d.csapak@proxmox.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.181 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pmg-devel] applied: [PATCH pmg-gui v3] StatTimeSelector: don't show invalid month/day combinations X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Oct 2022 11:58:59 -0000 Sorry for overlooking this one - gave it a quick spin and applied it. Huge Thanks! On Fri, 1 Jul 2022 13:42:00 +0200 Dominik Csapak wrote: > by limiting the store of the day selector by the selected month > > reported by a user in the forum: > https://forum.proxmox.com/threads/wrong-calendar.111631/ > > Reviewed-by: Thomas Lamprecht > Signed-off-by: Dominik Csapak > --- > changes from v2: > * got rid of unnecessary intermed. variables > * lookup instead of lookupReference > * shorter (one line) comment > * change function name to updateMaxDays > js/StatTimeSelector.js | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/js/StatTimeSelector.js b/js/StatTimeSelector.js > index f01b058..81958eb 100644 > --- a/js/StatTimeSelector.js > +++ b/js/StatTimeSelector.js > @@ -73,7 +73,20 @@ Ext.define('PMG.StatTimeSelector', { > Ext.GlobalEvents.fireEvent('pmgStatTimeSelectorUpdate', data); > }, > > + updateMaxDays: function() { > + let year = this.lookup('yearsel').getValue(); > + let month = this.lookup('monthsel').getValue(); > + // get last day of current month by wrapping back day 0 from next (zero indexed) month > + let maxDays = new Date(year, month, 0).getDate(); > + this.lookup('daysel').getStore().setFilters([{ > + property: 'day', > + operator: '<=', > + value: maxDays, > + }]); > + }, > + > onSelect: function() { > + this.updateMaxDays(); > this.updateVisibility(); > }, >