From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 04D27790BD for ; Fri, 1 Jul 2022 10:03:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E76897217 for ; Fri, 1 Jul 2022 10:03:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 1 Jul 2022 10:03:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E1DD740BCF for ; Fri, 1 Jul 2022 10:03:25 +0200 (CEST) From: Dominik Csapak To: pmg-devel@lists.proxmox.com Date: Fri, 1 Jul 2022 10:03:24 +0200 Message-Id: <20220701080324.1750557-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.099 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pmg-devel] [PATCH pmg-gui v2] StatTimeSelector: don't show invalid month/day combinations X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2022 08:03:57 -0000 by limiting the store of the day selector by the selected month reported by a user in the forum: https://forum.proxmox.com/threads/wrong-calendar.111631/ Signed-off-by: Dominik Csapak --- changes from v1: * use js 'Date' to correctly calculate the last day of the month including leapyears, etc. js/StatTimeSelector.js | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/js/StatTimeSelector.js b/js/StatTimeSelector.js index f01b058..eae2d91 100644 --- a/js/StatTimeSelector.js +++ b/js/StatTimeSelector.js @@ -73,7 +73,25 @@ Ext.define('PMG.StatTimeSelector', { Ext.GlobalEvents.fireEvent('pmgStatTimeSelectorUpdate', data); }, + updateDays: function() { + let yearsel = this.lookupReference('yearsel'); + let monthsel = this.lookupReference('monthsel'); + let daysel = this.lookupReference('daysel'); + let year = yearsel.getValue(); + let month = monthsel.getValue(); + // create a date for the next month, but day 0 which wraps to + // the last day of the current month. Our month is already + // 1 greater than what Date expects, so we don't have to add 1 + let maxDays = new Date(year, month, 0).getDate(); + daysel.getStore().setFilters([{ + property: 'day', + operator: '<=', + value: maxDays, + }]); + }, + onSelect: function() { + this.updateDays(); this.updateVisibility(); }, -- 2.30.2