From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9C0D583BFB for ; Tue, 7 Dec 2021 13:04:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8F0592B348 for ; Tue, 7 Dec 2021 13:04:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B72C22B332 for ; Tue, 7 Dec 2021 13:04:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 010EB44ED3 for ; Tue, 7 Dec 2021 12:53:35 +0100 (CET) From: Fabian Ebner To: pmg-devel@lists.proxmox.com Date: Tue, 7 Dec 2021 12:53:31 +0100 Message-Id: <20211207115331.67545-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211207115331.67545-1-f.ebner@proxmox.com> References: <20211207115331.67545-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.156 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH pmg-gui] sorters: use correct property 'direction' and keep default 'ASC' X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2021 12:04:36 -0000 Ext.util.Sorter does not have an 'order' property, so 'order: DESC' didn't have an effect. The default is 'ASC' and it is arguably the preferred direction for all affected sorters anyways. Signed-off-by: Fabian Ebner --- js/ActionList.js | 2 +- js/ClamAVDatabase.js | 2 +- js/LDAPConfig.js | 2 +- js/MailProxyTLSDestinations.js | 2 +- js/MyNetworks.js | 2 +- js/ObjectGroupList.js | 2 +- js/PBSConfig.js | 2 +- js/RelayDomains.js | 2 +- js/SpamDetectorStatus.js | 2 +- js/Transport.js | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/js/ActionList.js b/js/ActionList.js index bb13a5b..a94e3e1 100644 --- a/js/ActionList.js +++ b/js/ActionList.js @@ -31,7 +31,7 @@ Ext.define('PMG.ActionList', { }, sorters: { property: 'name', - order: 'DESC', + direction: 'ASC', }, }); diff --git a/js/ClamAVDatabase.js b/js/ClamAVDatabase.js index 884ffe1..d3f8e49 100644 --- a/js/ClamAVDatabase.js +++ b/js/ClamAVDatabase.js @@ -66,7 +66,7 @@ Ext.define('PMG.ClamAVDatabaseStatus', { }, sorters: { property: 'name', - order: 'DESC', + direction: 'ASC', }, }); diff --git a/js/LDAPConfig.js b/js/LDAPConfig.js index d7e4263..0a114ff 100644 --- a/js/LDAPConfig.js +++ b/js/LDAPConfig.js @@ -518,7 +518,7 @@ Ext.define('PMG.LDAPConfigGrid', { model: 'pmg-ldap-config', sorters: [{ property: 'profile', - order: 'DESC', + direction: 'ASC', }], }, diff --git a/js/MailProxyTLSDestinations.js b/js/MailProxyTLSDestinations.js index 0bdcc2a..04348c9 100644 --- a/js/MailProxyTLSDestinations.js +++ b/js/MailProxyTLSDestinations.js @@ -8,7 +8,7 @@ Ext.define('pmg-tls-policy', { }, sorters: { property: 'destination', - order: 'DESC', + direction: 'ASC', }, }); diff --git a/js/MyNetworks.js b/js/MyNetworks.js index 6c52f1a..975e21d 100644 --- a/js/MyNetworks.js +++ b/js/MyNetworks.js @@ -19,7 +19,7 @@ Ext.define('PMG.MyNetworks', { model: 'pmg-mynetworks', sorters: { property: 'cidr', - order: 'DESC', + direction: 'ASC', }, }); diff --git a/js/ObjectGroupList.js b/js/ObjectGroupList.js index 2e850e6..80dedc9 100644 --- a/js/ObjectGroupList.js +++ b/js/ObjectGroupList.js @@ -88,7 +88,7 @@ Ext.define('PMG.ObjectGroupList', { }, sorters: { property: 'name', - order: 'DESC', + direction: 'ASC', }, }); diff --git a/js/PBSConfig.js b/js/PBSConfig.js index 5e88574..3f09ccc 100644 --- a/js/PBSConfig.js +++ b/js/PBSConfig.js @@ -103,7 +103,7 @@ Ext.define('PMG.PBSConfigGrid', { model: 'pmg-pbs-config', sorters: [{ property: 'remote', - order: 'DESC', + direction: 'ASC', }], }, diff --git a/js/RelayDomains.js b/js/RelayDomains.js index 0098e20..ec43aa1 100644 --- a/js/RelayDomains.js +++ b/js/RelayDomains.js @@ -20,7 +20,7 @@ Ext.define('PMG.RelayDomains', { model: 'pmg-domains', sorters: { property: 'domain', - order: 'DESC', + direction: 'ASC', }, proxy: { type: 'proxmox', diff --git a/js/SpamDetectorStatus.js b/js/SpamDetectorStatus.js index 4b6d0fb..a0da9ff 100644 --- a/js/SpamDetectorStatus.js +++ b/js/SpamDetectorStatus.js @@ -94,7 +94,7 @@ Ext.define('PMG.SpamDetectorStatusGrid', { }, sorters: { property: 'name', - order: 'DESC', + direction: 'ASC', }, }); diff --git a/js/Transport.js b/js/Transport.js index 97a4aad..141fde1 100644 --- a/js/Transport.js +++ b/js/Transport.js @@ -20,7 +20,7 @@ Ext.define('PMG.Transport', { model: 'pmg-transport', sorters: { property: 'domain', - order: 'DESC', + direction: 'ASC', }, }); Proxmox.Utils.monStoreErrors(me, store, true); -- 2.30.2