From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A57C583C84 for ; Tue, 7 Dec 2021 13:05:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8786C2B347 for ; Tue, 7 Dec 2021 13:04:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B77FE2B333 for ; Tue, 7 Dec 2021 13:04:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9146D44F24 for ; Tue, 7 Dec 2021 12:53:34 +0100 (CET) From: Fabian Ebner To: pmg-devel@lists.proxmox.com Date: Tue, 7 Dec 2021 12:53:30 +0100 Message-Id: <20211207115331.67545-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.156 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH widget-toolkit] sorters: use correct property 'direction' and keep default 'ASC' X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2021 12:05:06 -0000 Ext.util.Sorter does not have an 'order' property, so 'order: DESC' didn't have an effect. The default is 'ASC' and it is arguably the preferred direction for realm anyways. Signed-off-by: Fabian Ebner --- I'll also send a patch for PVE later. PBS doesn't have this mistake anywhere AFAICS. src/panel/AuthView.js | 2 +- src/window/ACMEAccount.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/panel/AuthView.js b/src/panel/AuthView.js index 781e84e..69fe1a5 100644 --- a/src/panel/AuthView.js +++ b/src/panel/AuthView.js @@ -39,7 +39,7 @@ Ext.define('Proxmox.panel.AuthView', { model: 'pmx-domains', sorters: { property: 'realm', - order: 'DESC', + direction: 'ASC', }, }, diff --git a/src/window/ACMEAccount.js b/src/window/ACMEAccount.js index 05278a8..cf16736 100644 --- a/src/window/ACMEAccount.js +++ b/src/window/ACMEAccount.js @@ -45,7 +45,7 @@ Ext.define('Proxmox.window.ACMEAccountCreate', { proxy: { type: 'proxmox' }, sorters: { property: 'name', - order: 'ASC', + direction: 'ASC', }, }, listConfig: { -- 2.30.2