From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 501C0825DA for ; Mon, 29 Nov 2021 20:16:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3A63FE57F for ; Mon, 29 Nov 2021 20:16:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id CD179E56F for ; Mon, 29 Nov 2021 20:16:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9EE0345515 for ; Mon, 29 Nov 2021 20:16:06 +0100 (CET) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Mon, 29 Nov 2021 20:15:50 +0100 Message-Id: <20211129191550.315941-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.288 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH pmg-api] cli utils: chdir to / before running X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Nov 2021 19:16:40 -0000 some of PMG's CLI invocations switch user to postgres and run `psql` (through `PMG::Utils::postgres_admin_cmd()`) When running a command in `/root` (or any other directory not accessible by the postgres user this causes: `could not change directory to "/root": Permission denied` to be printed multiple times on stderr for those invocations, which is confusing and has caused quite a few support requests. grepping through the code-base setup_default_cli_env seems the appropriate place for chdir to /, since it's only called once per cli utility. quickly tested with `pmgconfig sync` Reported-by: Oguz Bektas Signed-off-by: Stoiko Ivanov --- src/PMG/RESTEnvironment.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PMG/RESTEnvironment.pm b/src/PMG/RESTEnvironment.pm index 3875720..49dd8e8 100644 --- a/src/PMG/RESTEnvironment.pm +++ b/src/PMG/RESTEnvironment.pm @@ -50,6 +50,7 @@ sub setup_default_cli_env { my $rest_env = $class->get(); $rest_env->set_role('root'); + chdir('/'); } sub set_format { -- 2.30.2