From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EFEEC81E28 for ; Fri, 26 Nov 2021 12:59:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EDE8517C76 for ; Fri, 26 Nov 2021 12:59:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DCB3917C68 for ; Fri, 26 Nov 2021 12:59:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7C819449F8 for ; Fri, 26 Nov 2021 12:59:26 +0100 (CET) Date: Fri, 26 Nov 2021 12:59:21 +0100 From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Message-ID: <20211126125921.312c773c@rosa.proxmox.com> In-Reply-To: <20211125192001.150932-1-s.ivanov@proxmox.com> References: <20211125192001.150932-1-s.ivanov@proxmox.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.295 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [bcc.pm, accept.pm, utils.pm, smtp.pm] Subject: [pmg-devel] applied-series: [PATCH pmg-api v3 0/2] fix #2795 - add DSN support X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Nov 2021 11:59:31 -0000 On Thu, 25 Nov 2021 20:19:59 +0100 Stoiko Ivanov wrote: > huge thanks again to Dominik for his testing and uncovering bugs! > > v2->v3: > * adapted the regular expression to also work if not parameters at all are > provided (as happens in after-queue filtering) > * added the DSN-EHLO keyword (else the first postfix instance did send the > notification - whereas we want to send the information on (so that a later > system sends it) > * tried a bit more systematic testing (including changing between before and > after queue filtering) > > original cover-letter for v2: > v1->v2: > * incorporated Dominik's feedback - huge thanks!! > * all parameters we don't care about are ignored (as before) > * the options are not transformed into lowercase unconditionally anymore > (they contain mail-addresses, and mail-ids - which are not case-insensitive) > * split up the patch into 2 commits - since the regexes for the MAIL and > RCPT commands is more sensitive than I expected: > ** read up on allowed characters in local-parts - tried extending the regex > to parse mailboxes more correctly - failed at that > ** decided it's ok to not allow '>' in localparts (we did not do so before) > ** did quite a bit more testing thanks to that > > Stoiko Ivanov (2): > partially fix #2795: allow for '>' in smtp parameters > fix #2795: add support for DSN > > src/PMG/RuleDB/Accept.pm | 2 +- > src/PMG/RuleDB/BCC.pm | 6 +++++- > src/PMG/SMTP.pm | 29 +++++++++++++++++++++++------ > src/PMG/Utils.pm | 19 ++++++++++++++++--- > src/bin/pmg-smtp-filter | 1 + > 5 files changed, 46 insertions(+), 11 deletions(-) > for completeness' sake applied with Dominik's R-b and T-b (see the thread of the v2)