From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BD3C78119D for ; Mon, 22 Nov 2021 20:50:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B2DAA2293F for ; Mon, 22 Nov 2021 20:50:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 33A9E22933 for ; Mon, 22 Nov 2021 20:50:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0C61E4551D for ; Mon, 22 Nov 2021 20:50:20 +0100 (CET) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Mon, 22 Nov 2021 20:50:10 +0100 Message-Id: <20211122195010.359005-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.319 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH pmg-api 1/1] rulesystem: limit linelength of disclaimer to 998 bytes X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2021 19:50:21 -0000 As described in http://www.postfix.org/postconf.5.html#smtp_line_length_limit postfix splits lines which are longer by inserting to adhere with RFC 5322 (section 2.1.1): https://datatracker.ietf.org/doc/html/rfc5322#section-2.1.1 If a longer line is part of the disclaimer pmg-smtp-filter adds it without this modification, which breaks DKIM signatures (since the body is modified by postfix after the body hash is computed) reported in our community forum: https://forum.proxmox.com/threads/dkim-body-has-been-altered-when-enabling-disclaimer-function.97919/ Signed-off-by: Stoiko Ivanov --- src/PMG/RuleDB/Disclaimer.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/PMG/RuleDB/Disclaimer.pm b/src/PMG/RuleDB/Disclaimer.pm index 1b1accf..1c81b03 100644 --- a/src/PMG/RuleDB/Disclaimer.pm +++ b/src/PMG/RuleDB/Disclaimer.pm @@ -84,6 +84,10 @@ sub save { defined($self->{ogroup}) || die "undefined object attribute: ERROR"; defined($self->{value}) || die "undefined object attribute: ERROR"; + if ($self->{value} =~ /^.{998,}$/m) { + die "too long line in disclaimer - breaks RFC 5322!\n"; + } + if (defined ($self->{id})) { # update -- 2.30.2