From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E9D36811A9 for ; Mon, 22 Nov 2021 20:50:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DF1A722931 for ; Mon, 22 Nov 2021 20:49:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 95CDE22926 for ; Mon, 22 Nov 2021 20:49:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 674614551D for ; Mon, 22 Nov 2021 20:49:55 +0100 (CET) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Mon, 22 Nov 2021 20:49:39 +0100 Message-Id: <20211122194939.358920-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.321 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH pmg-api 1/1] fix #3712: strip trailing dot from searchdomain X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2021 19:50:28 -0000 having a trailing '.' in the search domain is perfectly legal syntax (for domain names in general). postfix refuses to use a fqdn with trailing dot as hostname[0]. The restriction might be due to section 2.3.5 (Domain Names) of RFC5321 (a top-level domain is a single string without any dots) [1] [0] src/util/valid_hostname.c in the postfix source [1] https://datatracker.ietf.org/doc/html/rfc5321#section-2.3.5 Signed-off-by: Stoiko Ivanov --- src/PMG/Config.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PMG/Config.pm b/src/PMG/Config.pm index cbcda6e..31f9c6f 100755 --- a/src/PMG/Config.pm +++ b/src/PMG/Config.pm @@ -1278,6 +1278,8 @@ sub get_host_dns_info { my $resolv = PVE::INotify::read_file('resolvconf'); my $domain = $resolv->{search} // 'localdomain'; + # postfix will not parse a hostname with trailing '.' + $domain =~ s/^(.*)\.$/$1/; $dnsinfo->{domain} = $domain; $dnsinfo->{fqdn} = "$nodename.$domain"; -- 2.30.2