From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1E0D879B21 for ; Wed, 27 Oct 2021 17:03:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 178F015E37 for ; Wed, 27 Oct 2021 17:02:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 513A015E1F for ; Wed, 27 Oct 2021 17:02:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 263C14351C for ; Wed, 27 Oct 2021 17:02:30 +0200 (CEST) From: Dominik Csapak To: pmg-devel@lists.proxmox.com Date: Wed, 27 Oct 2021 17:02:29 +0200 Message-Id: <20211027150229.2610534-3-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211027150229.2610534-1-d.csapak@proxmox.com> References: <20211027150229.2610534-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.264 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH pmg-gui 1/1] fix #3648: ldap config: do not send empty bindpw X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2021 15:03:01 -0000 so that we can reuse the saved one and the admin does not have to enter the password on each config change (similar to PVE). Signed-off-by: Dominik Csapak --- js/LDAPConfig.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/js/LDAPConfig.js b/js/LDAPConfig.js index 19ec702..d7e4263 100644 --- a/js/LDAPConfig.js +++ b/js/LDAPConfig.js @@ -28,6 +28,11 @@ Ext.define('PMG.LDAPInputPanel', { values.disable = values.enable ? 0 : 1; delete values.enable; + // do not send empty password + if (values.bindpw === '') { + delete values.bindpw; + } + return values; }, @@ -103,6 +108,7 @@ Ext.define('PMG.LDAPInputPanel', { xtype: 'textfield', inputType: 'password', allowBlank: true, + emptyText: gettext('Unchanged'), name: 'bindpw', fieldLabel: gettext('Password'), }, -- 2.30.2