From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7C767761AC for ; Wed, 14 Jul 2021 19:41:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6DFE015752 for ; Wed, 14 Jul 2021 19:41:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E8C4A15744 for ; Wed, 14 Jul 2021 19:41:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C027E4180C for ; Wed, 14 Jul 2021 19:41:58 +0200 (CEST) Date: Wed, 14 Jul 2021 19:41:57 +0200 From: Stoiko Ivanov To: Fabian Ebner Cc: pmg-devel@lists.proxmox.com Message-ID: <20210714194157.25278eb3@rosa.proxmox.com> In-Reply-To: <20210714125548.87873-1-f.ebner@proxmox.com> References: <20210714125548.87873-1-f.ebner@proxmox.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.440 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH proxmox-widget-toolkit 1/1] node: repos: add online help X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2021 17:41:59 -0000 Thanks for the patch! applied both, and tried it out - works as advertised! FWIW: Reviewed-by: Stoiko Ivanov Tested-by: Stoiko Ivanov On Wed, 14 Jul 2021 14:55:47 +0200 Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > src/node/APTRepositories.js | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js > index c7222fc..9b74980 100644 > --- a/src/node/APTRepositories.js > +++ b/src/node/APTRepositories.js > @@ -141,6 +141,7 @@ Ext.define('Proxmox.node.APTRepositoriesErrors', { > Ext.define('Proxmox.node.APTRepositoriesGrid', { > extend: 'Ext.grid.GridPanel', > xtype: 'proxmoxNodeAPTRepositoriesGrid', > + mixins: ['Proxmox.Mixin.CBind'], > > title: gettext('APT Repositories'), > > @@ -162,6 +163,9 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', { > name: 'addRepo', > disabled: true, > repoInfo: undefined, > + cbind: { > + onlineHelp: '{onlineHelp}', > + }, > handler: function(button, event, record) { > Proxmox.Utils.checked_command(() => { > let me = this; > @@ -177,6 +181,7 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', { > url: `/api2/extjs/nodes/${panel.nodename}/apt/repositories`, > method: 'PUT', > extraRequestParams: extraParams, > + onlineHelp: me.onlineHelp, > listeners: { > destroy: function() { > panel.reload(); > @@ -410,6 +415,8 @@ Ext.define('Proxmox.node.APTRepositories', { > > digest: undefined, > > + onlineHelp: undefined, > + > product: 'Proxmox VE', // default > > controller: { > @@ -575,6 +582,7 @@ Ext.define('Proxmox.node.APTRepositories', { > flex: 1, > cbind: { > nodename: '{nodename}', > + onlineHelp: '{onlineHelp}', > }, > majorUpgradeAllowed: false, // TODO get release information from an API call? > listeners: {