From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 64DEB75AAC for ; Tue, 13 Jul 2021 14:26:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5C3F222B13 for ; Tue, 13 Jul 2021 14:26:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4EB4522AFD for ; Tue, 13 Jul 2021 14:26:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 209CD4103C for ; Tue, 13 Jul 2021 14:26:15 +0200 (CEST) From: Fabian Ebner To: pmg-devel@lists.proxmox.com Date: Tue, 13 Jul 2021 14:26:10 +0200 Message-Id: <20210713122610.72675-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210713122610.72675-1-f.ebner@proxmox.com> References: <20210713122610.72675-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.512 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH pmg-gui 2/2] dashboard: hide cluster resources if it's a single node X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 12:26:16 -0000 Signed-off-by: Fabian Ebner --- Not sure about initially hiding or not. To avoid the component jumping in (if initially hidden and it is a cluster) or out (if initially visible and it is not a cluster), we'd need to wait for the cluster status to load before rendering... js/Dashboard.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/js/Dashboard.js b/js/Dashboard.js index 79817b3..8f08f8c 100644 --- a/js/Dashboard.js +++ b/js/Dashboard.js @@ -142,6 +142,9 @@ Ext.define('PMG.Dashboard', { me.lookup('nodeInfo').setSubscriptionStatus(subStatus); + // the node info already displays this information in case there is no cluster + me.lookup('clusterResources').setHidden(records.length === 1); + cpu = cpu/count; mem = mem/count; hd = hd/count; @@ -412,6 +415,8 @@ Ext.define('PMG.Dashboard', { height: 250, iconCls: 'fa fa-tasks', title: gettext('Cluster Resources (average)'), + reference: 'clusterResources', + hidden: true, bodyPadding: '0 20 0 20', layout: { type: 'hbox', -- 2.30.2