From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BD1AA723EA for ; Tue, 15 Jun 2021 15:33:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AF6F22EF2E for ; Tue, 15 Jun 2021 15:33:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 92F662EF23 for ; Tue, 15 Jun 2021 15:33:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D8B4742FB7 for ; Tue, 15 Jun 2021 15:27:55 +0200 (CEST) From: Fabian Ebner To: pmg-devel@lists.proxmox.com Date: Tue, 15 Jun 2021 15:27:52 +0200 Message-Id: <20210615132752.191661-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.772 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [nodes.pm] Subject: [pmg-devel] [PATCH pmg-api] api: nodes: add definedness check to avoid perl warning X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jun 2021 13:33:17 -0000 also add the missing import for 'raise_perm_exc' to avoid having the error about the undefined subroutine instead of the actual error. Signed-off-by: Fabian Ebner --- src/PMG/API2/Nodes.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PMG/API2/Nodes.pm b/src/PMG/API2/Nodes.pm index f9ccfae..e41194b 100644 --- a/src/PMG/API2/Nodes.pm +++ b/src/PMG/API2/Nodes.pm @@ -6,6 +6,7 @@ use Time::Local qw(timegm_nocheck); use Filesys::Df; use Data::Dumper; +use PVE::Exception qw(raise_perm_exc); use PVE::INotify; use PVE::RESTHandler; use PVE::JSONSchema qw(get_standard_option); @@ -428,7 +429,9 @@ __PACKAGE__->register_method ({ my $restenv = PMG::RESTEnvironment->get(); my $user = $restenv->get_user(); - raise_perm_exc('user != root@pam') if $param->{cmd} eq 'upgrade' && $user ne 'root@pam'; + if (defined($param->{cmd}) && $param->{cmd} eq 'upgrade' && $user ne 'root@pam') { + raise_perm_exc('user != root@pam'); + } my $ticket = PMG::Ticket::assemble_vnc_ticket($user, $authpath); -- 2.30.2