From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F3A9E736D8 for ; Thu, 15 Apr 2021 21:46:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CFA661DF35 for ; Thu, 15 Apr 2021 21:46:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A15431DF0B for ; Thu, 15 Apr 2021 21:46:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 654A645B1E for ; Thu, 15 Apr 2021 21:46:33 +0200 (CEST) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Thu, 15 Apr 2021 21:46:20 +0200 Message-Id: <20210415194622.25632-4-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210415194622.25632-1-s.ivanov@proxmox.com> References: <20210415194622.25632-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.059 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [nodeconfig.pm] Subject: [pmg-devel] [PATCH pmg-api v3 3/3] nodeconfig: parse acme config before writing X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2021 19:46:35 -0000 we use `get_acme_conf` as higher level sanity checker (e.g. to ensure that wildcard certificates have a configured DNS plugin) (adapted from pve-manger (where this is done in the corresponding API call) Signed-off-by: Stoiko Ivanov --- src/PMG/NodeConfig.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PMG/NodeConfig.pm b/src/PMG/NodeConfig.pm index 029b903..42139e4 100644 --- a/src/PMG/NodeConfig.pm +++ b/src/PMG/NodeConfig.pm @@ -131,6 +131,9 @@ sub read_pmg_node_config { sub write_pmg_node_config { my ($filename, $fh, $cfg) = @_; my $raw = PVE::JSONSchema::dump_config($config_schema, $filename, $cfg); + + # higher level ACME sanity checking + get_acme_conf($cfg); PVE::Tools::safe_print($filename, $fh, $raw); } -- 2.20.1