From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 389C773781 for ; Thu, 15 Apr 2021 21:47:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 300041DF46 for ; Thu, 15 Apr 2021 21:46:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6F61C1DF36 for ; Thu, 15 Apr 2021 21:46:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3B98345AC7 for ; Thu, 15 Apr 2021 21:46:35 +0200 (CEST) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Thu, 15 Apr 2021 21:46:19 +0200 Message-Id: <20210415194622.25632-3-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210415194622.25632-1-s.ivanov@proxmox.com> References: <20210415194622.25632-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [ietf.org, nodeconfig.pm] Subject: [pmg-devel] [PATCH pmg-api v3 2/3] acme: check plugin for wildcard certificates X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Apr 2021 19:47:06 -0000 Let's Encrypt currently only issues wildcard certificates if the domain ownership is validated via a dns-01 type plugin. Signed-off-by: Stoiko Ivanov --- src/PMG/NodeConfig.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PMG/NodeConfig.pm b/src/PMG/NodeConfig.pm index 5f96e62..029b903 100644 --- a/src/PMG/NodeConfig.pm +++ b/src/PMG/NodeConfig.pm @@ -209,9 +209,9 @@ sub get_acme_conf { } $parsed->{plugin} //= 'standalone'; + my $plugins = PMG::API2::ACMEPlugin::load_config(); my $plugin_id = $parsed->{plugin}; if ($plugin_id ne 'standalone') { - my $plugins = PMG::API2::ACMEPlugin::load_config(); die "plugin '$plugin_id' for domain '$domain' not found!\n" if !$plugins->{ids}->{$plugin_id}; } @@ -220,6 +220,9 @@ sub get_acme_conf { # wildcard - see https://tools.ietf.org/html/rfc8555#section-7.1.3 if ($domain =~ /^\*\.(.*)$/ ) { $res->{validationtarget}->{$1} = $domain; + die "wildcard domain validation for '$domain' needs a dns-01 plugin.\n" + if $plugins->{ids}->{$plugin_id}->{type} ne 'dns'; + } $parsed->{_configkey} = "acmedomain$index"; -- 2.20.1