From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 874026D0BC for ; Wed, 31 Mar 2021 13:44:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 699FEEEEA for ; Wed, 31 Mar 2021 13:44:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 45615EEDA for ; Wed, 31 Mar 2021 13:44:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 13EB8427DC for ; Wed, 31 Mar 2021 13:44:22 +0200 (CEST) Date: Wed, 31 Mar 2021 13:44:21 +0200 From: Stoiko Ivanov To: Thomas Lamprecht Cc: pmg-devel@lists.proxmox.com Message-ID: <20210331134421.70674821@rosa.proxmox.com> In-Reply-To: <20210330150547.21333-1-t.lamprecht@proxmox.com> References: <20210330150547.21333-1-t.lamprecht@proxmox.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [quarantine.pm] Subject: [pmg-devel] applied: [PATCH] fix #2228: automatically deliver/delete on whitelist/blacklist X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Mar 2021 11:44:53 -0000 On Tue, 30 Mar 2021 17:05:47 +0200 Thomas Lamprecht wrote: > If a user chooses to blacklist a specific sender of a mail, the mail > is highly probably undesired too, so delete it in that case. > > The reverse should hold for white listing a mail's sender, deliver it > in that case. > > Signed-off-by: Thomas Lamprecht > --- > > The bug report talked about doing this opt-out, but I really do not see when > one would think along the lines of "that sender is always spam, blacklist them > but keep that specific mail" so just do it unconditionally. > > src/PMG/API2/Quarantine.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/PMG/API2/Quarantine.pm b/src/PMG/API2/Quarantine.pm > index 848ae8e..2fa1bb4 100644 > --- a/src/PMG/API2/Quarantine.pm > +++ b/src/PMG/API2/Quarantine.pm > @@ -1228,8 +1228,10 @@ __PACKAGE__->register_method ({ > > if ($action eq 'whitelist') { > PMG::Quarantine::add_to_blackwhite($dbh, $ref->{pmail}, 'WL', [ $sender ]); > + PMG::Quarantine::deliver_quarantined_mail($dbh, $ref, $ref->{receiver} // $ref->{pmail}); > } elsif ($action eq 'blacklist') { > PMG::Quarantine::add_to_blackwhite($dbh, $ref->{pmail}, 'BL', [ $sender ]); > + PMG::Quarantine::delete_quarantined_mail($dbh, $ref); > } elsif ($action eq 'deliver') { > PMG::Quarantine::deliver_quarantined_mail($dbh, $ref, $ref->{receiver} // $ref->{pmail}); > } elsif ($action eq 'delete') { reviewed, tested and applied the patch (with my R-b, T-b tags) - huge thanks!