From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 01EC86912C for ; Mon, 1 Mar 2021 15:13:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C7463211A4 for ; Mon, 1 Mar 2021 15:12:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 722492114B for ; Mon, 1 Mar 2021 15:12:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 344614581B for ; Mon, 1 Mar 2021 15:12:48 +0100 (CET) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Mon, 1 Mar 2021 15:12:20 +0100 Message-Id: <20210301141225.18394-4-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210301141225.18394-1-s.ivanov@proxmox.com> References: <20210301141225.18394-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.309 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_SBL 0.644 Contains an URL's NS IP listed in the Spamhaus SBL blocklist [backup.pm] URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist [backup.pm] Subject: [pmg-devel] [PATCH pmg-api v2 3/3] backup: add notify parameter to 'classic' backup X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Mar 2021 14:13:20 -0000 for feature-parity, and since we recently had a user in our community forum, who does regular backups via cron+rsync (small site w/o dedicated backup host). Those setups could also benefit from this. Signed-off-by: Stoiko Ivanov --- src/PMG/API2/Backup.pm | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/PMG/API2/Backup.pm b/src/PMG/API2/Backup.pm index 4ea28d1..2248fa5 100644 --- a/src/PMG/API2/Backup.pm +++ b/src/PMG/API2/Backup.pm @@ -110,6 +110,13 @@ __PACKAGE__->register_method ({ optional => 1, default => 1, }, + notify => { + description => "Specify when to notify via e-mail", + type => 'string', + enum => [ 'always', 'error', 'never' ], + optional => 1, + default => 'never', + }, }, }, returns => { type => "string" }, @@ -129,11 +136,21 @@ __PACKAGE__->register_method ({ my $worker = sub { my $upid = shift; - print "starting backup to: $filename\n"; + my $full_log = ""; + my $log = sub { print "$_[0]\n"; $full_log .= "$_[0]\n"; }; + + $log->("starting backup to: $filename\n"); + + eval { PMG::Backup::pmg_backup_pack($filename, $param->{statistic}) }; + if (my $err = $@) { + $log->($err); + PMG::Backup::send_backup_notification($param->{notify}, undef, $full_log, $err); + die "backup failed: $err\n"; + } - PMG::Backup::pmg_backup_pack($filename, $param->{statistic}); + $log->("backup finished\n"); - print "backup finished\n"; + PMG::Backup::send_backup_notification($param->{notify}, undef, $full_log, undef); return; }; -- 2.20.1