From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2315B6A01D for ; Thu, 21 Jan 2021 16:51:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 20A3913D67 for ; Thu, 21 Jan 2021 16:51:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0CEA713D5F for ; Thu, 21 Jan 2021 16:51:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CBC2A460B6 for ; Thu, 21 Jan 2021 16:51:38 +0100 (CET) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Thu, 21 Jan 2021 16:51:06 +0100 Message-Id: <20210121155107.1971-6-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210121155107.1971-1-s.ivanov@proxmox.com> References: <20210121155107.1971-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.066 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, ietf.org, utils.pm] Subject: [pmg-devel] [PATCH pmg-api v2 5/5] utils: allow '/' inside email address localpart X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2021 15:51:40 -0000 The change is motivated by a report in our community forum [0], where a mail addressed to an address containing '/' in its local-part ended up in the quarantine. This is permitted by RFC5322 ([1]), and, probably more relevant, happily accepted and processed by postfix. Once inside the quarantine (or the statistic database) the records cannot be displayed (due to the parameter verification failure). This leaves the user unable to delete the quarantined mail. Apart from the quarantine and statistics the 'pmg-email-address' format is only used in the PBSConfig and the fetchmail configuration (both of which are available only to the admin and can be still be edited irrespective of the set localpart). [0] https://forum.proxmox.com/threads/pmg-error-parameter-verification-failed-400.82353/ [1] https://tools.ietf.org/html/rfc5322 Signed-off-by: Stoiko Ivanov --- src/PMG/Utils.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PMG/Utils.pm b/src/PMG/Utils.pm index 149bcdc..4341dbd 100644 --- a/src/PMG/Utils.pm +++ b/src/PMG/Utils.pm @@ -117,7 +117,7 @@ PVE::JSONSchema::register_standard_option('username', { PVE::JSONSchema::register_standard_option('pmg-email-address', { description => "Email Address (allow most characters).", type => 'string', - pattern => '(?:[^\s\/\\\@]+\@[^\s\/\\\@]+)', + pattern => '(?:[^\s\\\@]+\@[^\s\/\\\@]+)', maxLength => 512, minLength => 3, }); -- 2.20.1