From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C4C6968D86 for ; Fri, 15 Jan 2021 10:47:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BAC0922DD5 for ; Fri, 15 Jan 2021 10:46:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 767E022DA7 for ; Fri, 15 Jan 2021 10:46:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3AE9945250 for ; Fri, 15 Jan 2021 10:46:47 +0100 (CET) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Fri, 15 Jan 2021 10:46:21 +0100 Message-Id: <20210115094626.25440-2-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210115094626.25440-1-s.ivanov@proxmox.com> References: <20210115094626.25440-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.071 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [statistics.pm] Subject: [pmg-devel] [PATCH pmg-api 1/5] api: statistics: remove unneeded RESTEnvironment X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jan 2021 09:47:19 -0000 none of the API calls in PMG::API2::Statistics use the RESTEnvironment - so remove the unused code. Signed-off-by: Stoiko Ivanov --- src/PMG/API2/Statistics.pm | 34 ---------------------------------- 1 file changed, 34 deletions(-) diff --git a/src/PMG/API2/Statistics.pm b/src/PMG/API2/Statistics.pm index 7eb8d18..adc7650 100644 --- a/src/PMG/API2/Statistics.pm +++ b/src/PMG/API2/Statistics.pm @@ -238,9 +238,6 @@ __PACKAGE__->register_method ({ code => sub { my ($param) = @_; - my $restenv = PMG::RESTEnvironment->get(); - my $cinfo = $restenv->{cinfo}; - my ($start, $end) = $extract_start_end->($param); my $cfg = PMG::Config->new(); @@ -383,9 +380,6 @@ __PACKAGE__->register_method ({ code => sub { my ($param) = @_; - my $restenv = PMG::RESTEnvironment->get(); - my $cinfo = $restenv->{cinfo}; - my ($start, $end) = $extract_start_end->($param); my $stat = PMG::Statistic->new($start, $end); @@ -530,9 +524,6 @@ __PACKAGE__->register_method ({ code => sub { my ($param) = @_; - my $restenv = PMG::RESTEnvironment->get(); - my $cinfo = $restenv->{cinfo}; - my ($start, $end) = $extract_start_end->($param); my $cfg = PMG::Config->new(); @@ -684,9 +675,6 @@ __PACKAGE__->register_method ({ code => sub { my ($param) = @_; - my $restenv = PMG::RESTEnvironment->get(); - my $cinfo = $restenv->{cinfo}; - my ($start, $end) = $extract_start_end->($param); my $stat = PMG::Statistic->new($start, $end); @@ -791,9 +779,6 @@ __PACKAGE__->register_method ({ code => sub { my ($param) = @_; - my $restenv = PMG::RESTEnvironment->get(); - my $cinfo = $restenv->{cinfo}; - my ($start, $end) = $extract_start_end->($param); my $stat = PMG::Statistic->new($start, $end); @@ -910,8 +895,6 @@ __PACKAGE__->register_method ({ code => sub { my ($param) = @_; - my $restenv = PMG::RESTEnvironment->get(); - my $hours = $param->{hours} // 12; my $span = $param->{timespan} // 1800; @@ -972,8 +955,6 @@ __PACKAGE__->register_method ({ code => sub { my ($param) = @_; - my $restenv = PMG::RESTEnvironment->get(); - my $hours = $param->{hours} // 12; my $limit = $param->{limit} // 5; @@ -1071,9 +1052,6 @@ __PACKAGE__->register_method ({ code => sub { my ($param) = @_; - my $restenv = PMG::RESTEnvironment->get(); - my $cinfo = $restenv->{cinfo}; - my ($start, $end) = $extract_start_end->($param); my $span = $param->{timespan} // 3600; @@ -1138,9 +1116,6 @@ __PACKAGE__->register_method ({ code => sub { my ($param) = @_; - my $restenv = PMG::RESTEnvironment->get(); - my $cinfo = $restenv->{cinfo}; - my ($start, $end) = $extract_start_end->($param); my $stat = PMG::Statistic->new($start, $end); @@ -1185,9 +1160,6 @@ __PACKAGE__->register_method ({ code => sub { my ($param) = @_; - my $restenv = PMG::RESTEnvironment->get(); - my $cinfo = $restenv->{cinfo}; - my ($start, $end) = $extract_start_end->($param); my $stat = PMG::Statistic->new($start, $end); @@ -1284,9 +1256,6 @@ __PACKAGE__->register_method ({ code => sub { my ($param) = @_; - my $restenv = PMG::RESTEnvironment->get(); - my $cinfo = $restenv->{cinfo}; - my ($start, $end) = $extract_start_end->($param); my $stat = PMG::Statistic->new($start, $end); @@ -1345,9 +1314,6 @@ __PACKAGE__->register_method ({ code => sub { my ($param) = @_; - my $restenv = PMG::RESTEnvironment->get(); - my $cinfo = $restenv->{cinfo}; - my ($start, $end) = $extract_start_end->($param); my $span = $param->{timespan} // 3600; -- 2.20.1