From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7DDA360D1B for ; Wed, 18 Nov 2020 15:53:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7BE021D40E for ; Wed, 18 Nov 2020 15:53:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 27F1F1D3F1 for ; Wed, 18 Nov 2020 15:53:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EC198439CD for ; Wed, 18 Nov 2020 15:53:16 +0100 (CET) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Wed, 18 Nov 2020 15:52:54 +0100 Message-Id: <20201118145254.26214-3-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201118145254.26214-1-s.ivanov@proxmox.com> References: <20201118145254.26214-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.091 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mailqueue.pm] Subject: [pmg-devel] [PATCH pmg-api 2/2] do not create /cluster/ unconditionally X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Nov 2020 14:53:18 -0000 while looking through the spooldir creation we noticed the mkdir call on a relative path. This creates a '/cluster//' directory on each system which has a cluster.conf ( being the node's clusterid). This is not used since the spooldirs are in '/var/spool/pmg/cluster/' Simply drop the mkdir call, since the spooldirs get created upon cluster creation (PMG::API2::Cluster::create) and joining to an existing cluster. Reported-by: Dominik Csapak Signed-off-by: Stoiko Ivanov --- src/PMG/MailQueue.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/src/PMG/MailQueue.pm b/src/PMG/MailQueue.pm index e0f56b9..435f168 100644 --- a/src/PMG/MailQueue.pm +++ b/src/PMG/MailQueue.pm @@ -285,7 +285,6 @@ sub quarantine_mail { eval { if ($lcid) { my $subdir = "cluster/$lcid/$subpath"; - mkpath $subdir; ($fh, $uid, $path) = new_fileid ($spooldir, $subdir); } else { ($fh, $uid, $path) = new_fileid ($spooldir, $subpath); -- 2.20.1