From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 219B269384 for ; Thu, 12 Nov 2020 18:58:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1935613A05 for ; Thu, 12 Nov 2020 18:58:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E3EED139F5 for ; Thu, 12 Nov 2020 18:58:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A92AA424BE for ; Thu, 12 Nov 2020 18:58:10 +0100 (CET) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com Date: Thu, 12 Nov 2020 18:57:57 +0100 Message-Id: <20201112175757.25201-3-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201112175757.25201-1-s.ivanov@proxmox.com> References: <20201112175757.25201-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.089 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH pmg-gui 2/2] RegexTester: find correct component X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2020 17:58:42 -0000 the regular expression field is not necessarily after the regex tester (mostly it is before). In order to be more robust, use child instead of previousSibling Tested with: * mailproxy whitelist * match field * match filename * who object Signed-off-by: Stoiko Ivanov --- Thanks to Dominik for pointing me in the right direction! js/RegexTester.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/RegexTester.js b/js/RegexTester.js index 3b03f6d..486c197 100644 --- a/js/RegexTester.js +++ b/js/RegexTester.js @@ -26,7 +26,7 @@ Ext.define('PMG.RegexTester', { text: 'Test', handler: function(btn) { let view = this.up(); - let regexField = btn.nextSibling(`field[reference=${view.regexFieldReference}]`); + let regexField = view.up().child(`field[reference=${view.regexFieldReference}]`); let regex = regexField.getValue(); if (view.wholeMatch) { -- 2.20.1