From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5E7368B526 for ; Sat, 22 Oct 2022 15:38:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3E7402A510 for ; Sat, 22 Oct 2022 15:37:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Sat, 22 Oct 2022 15:37:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 84B4D449E5 for ; Sat, 22 Oct 2022 15:37:30 +0200 (CEST) Message-ID: <1fba7b13-cda2-14b3-7b16-c720b29c33ba@proxmox.com> Date: Sat, 22 Oct 2022 15:37:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Thunderbird/106.0 Content-Language: en-GB To: Stoiko Ivanov , pmg-devel@lists.proxmox.com References: <20221020191500.2414-1-s.ivanov@proxmox.com> <20221020191500.2414-4-s.ivanov@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221020191500.2414-4-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH pmg-gui 3/4] quarantine: add common controller for all quarantines X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2022 13:38:08 -0000 Am 20/10/2022 um 21:14 schrieb Stoiko Ivanov: > over the time the spam quarantine has gained quite a few nice > usability improvments and features, which would be useful in > the virus and attachment quarantines as well - e.g.: > > * multi-mail selection > * keyboard actions > * context menu > * download mail as .eml > > by adding the common class (which is mostly a copy of the controller > part of SpamQuarantine.js with changes of 'var' to 'let' and removal of the > spam-specific parts), we can reuse it for all the quarantines. > great re-use! Can you please move the original implementation in SpamQuarantine directly over in this path, that'd would better separate the "factor out" and "add new functionality to components" parts. > Signed-off-by: Stoiko Ivanov > --- > js/Makefile | 1 + > js/controller/QuarantineController.js | 170 ++++++++++++++++++++++++++ > 2 files changed, 171 insertions(+) > create mode 100644 js/controller/QuarantineController.js > > diff --git a/js/Makefile b/js/Makefile > index b904598..9a2bcf2 100644 > --- a/js/Makefile > +++ b/js/Makefile > @@ -19,6 +19,7 @@ JSSRC= \ > RuleInfo.js \ > RuleEditor.js \ > MainView.js \ > + controller/QuarantineController.js \ > QuarantineContextMenu.js \ > QuarantineList.js \ > SpamInfoGrid.js \ > diff --git a/js/controller/QuarantineController.js b/js/controller/QuarantineController.js > new file mode 100644 > index 0000000..dfe2915 > --- /dev/null > +++ b/js/controller/QuarantineController.js > @@ -0,0 +1,170 @@ > +Ext.define('PMG.controller.QuarantineController', { I'd drop the 'Controller' at the end, if one uses the full path to instantiate/refer to this, it's already clear that it's a controller due to the middle part. > + extend: 'Ext.app.ViewController', > + xtype: 'controller.Quarantine', xtype doesn't gets the controller. part, and please keep our general style of prefixing with the product abbrev, e.g.: 'pmgQuarantine' > + alias: 'controller.quarantine', I guess both as the "wrong" xtype did not work? anyhow, either xtype or alias, but not both. I've lessend my strong preference of one of them more recently, so I don't care much which one, more for only using one, not both.