From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8EEB561015 for ; Thu, 19 Nov 2020 10:08:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 83FB222D93 for ; Thu, 19 Nov 2020 10:08:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C1BA322D86 for ; Thu, 19 Nov 2020 10:08:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 88B40438D3 for ; Thu, 19 Nov 2020 10:08:17 +0100 (CET) Date: Thu, 19 Nov 2020 10:08:11 +0100 (CET) From: Dietmar Maurer To: Stoiko Ivanov Cc: pmg-devel@lists.proxmox.com Message-ID: <1960109923.283.1605776891993@webmail.proxmox.com> In-Reply-To: <20201119094053.66c3ab49@rosa.proxmox.com> References: <20201118175935.11516-1-s.ivanov@proxmox.com> <20201118175935.11516-2-s.ivanov@proxmox.com> <1392664598.271.1605724464296@webmail.proxmox.com> <20201119094053.66c3ab49@rosa.proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.4-Rev13 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.117 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pmg-devel] [PATCH pmg-api 1/2] pbs: api: add statistic parameter to run_backup X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2020 09:08:18 -0000 > On 11/19/2020 9:40 AM Stoiko Ivanov wrote: > > > On Wed, 18 Nov 2020 19:34:23 +0100 (CET) > Dietmar Maurer wrote: > > > why does this default => 1 ? > mostly to mirror the way it is with the local-backup (to tar.gz): > https://git.proxmox.com/?p=pmg-api.git;a=blob;f=src/PMG/API2/Backup.pm;h=4ea28d13e28f23956ec7e0ff64e77ea04a333a53;hb=HEAD#l122 > > I also think that we should rather backup more than less in the default > case - I personally be more disappointed to lose my year long statistics > in case of disaster than about ~100 M (estimated based on our > productive instance) more space on my backupstorage. > You do have a point regarding size (backup without statistics is usually < > 500k vs 100M) though - so making this comfortably configurable would be a > nice enhancement! > > Making this actually user-selectable (apart from a direct API-call or > using `pmgbackup` manually) would need exposing this in the GUI (and > somehow getting it in the systemd-service units). > > Would recording this in bugzilla work for you? sure