From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BE7611FF14F for ; Wed, 17 Jun 2026 13:52:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D63A32522; Wed, 17 Jun 2026 13:52:13 +0200 (CEST) From: Stoiko Ivanov To: pmg-devel@lists.proxmox.com, Dominik Csapak Subject: applied: [PATCH log-tracker v2 1/3] split out pmg-smtp-filter qid parsing Date: Wed, 17 Jun 2026 13:51:46 +0200 Message-ID: <178169700491.30353.9624843726718278475.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260617074934.955079-1-d.csapak@proxmox.com> References: <20260617074934.955079-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781697072702 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.083 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HIZFEXN2VVVP26BHWIFTGGULE7CRC5BQ X-Message-ID-Hash: HIZFEXN2VVVP26BHWIFTGGULE7CRC5BQ X-MailFrom: s.ivanov@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the quick iteration on this and the explanations on my comments! Gave it another look, ran some more benchmarks on some live syslogs, and additionally compared the (sorted) output with your patch and without with those logs - looked ok. On Wed, 17 Jun 2026 09:47:48 +0200, Dominik Csapak wrote: > By splitting out the parsing of the pmg-smtp-filter QIDs, we can more > rigorously parse them since the parser does not have to overlap with > postfix's QIDs'. We have a bit of code duplication, but more clarity > when reading the code and better checks. > > Since we know how long the pmg-smtp-filter QIDs must be, we can also > filter by the length. > > [...] Applied, thanks! [1/3] split out pmg-smtp-filter qid parsing commit: e90400ddadb396197a5b677109c86d5681a75e64 [2/3] parse_qid{_prefix}: remove 'max' parameter commit: 129d533dedff1a554c04fa3c113564c23df98415 [3/3] fix #7702: improve postfix QID parsing commit: 83c77b7da75bf9e9d41c3526401c9a2024ad0c60