From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8E9021FF13A for ; Wed, 10 Jun 2026 11:57:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6758C8836; Wed, 10 Jun 2026 11:57:58 +0200 (CEST) From: Thomas Lamprecht To: pmg-devel@lists.proxmox.com, Stoiko Ivanov Subject: applied: [PATCH pmg-api] config: smtp-welcomelist: avoid short-circuiting due to side-effects Date: Wed, 10 Jun 2026 11:57:40 +0200 Message-ID: <178108545876.3842880.16149101362296571032.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260610091356.958395-1-s.ivanov@proxmox.com> References: <20260610091356.958395-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781085423919 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [master.cf] Message-ID-Hash: ZVMTVWBEJL3B7Z57FQVCQUO4GSXEAATY X-Message-ID-Hash: ZVMTVWBEJL3B7Z57FQVCQUO4GSXEAATY X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 10 Jun 2026 11:13:53 +0200, Stoiko Ivanov wrote: > the version with the post-if also reads a bit nicer to me. > > a similar issue was fixed in 2022: > 991d8f1c ("pmg-daily: avoid short-circuting update of local channels") > > minimally tested by: > * removing all smtp-welcomelist files in /etc/postfix and their > postmap .db result (senderaccess rcptaccess clientaccess > postscreen_access) > * manually modifying /etc/postfix/master.cf (adding a -v to smtpd) > * adding an entry to the Mail Proxy Welcomelist in the GUI > * checking that all files were created and that postfix was reloaded > > [...] Applied, thanks! [1/1] config: smtp-welcomelist: avoid short-circuiting due to side-effects commit: 02f0186c63e984e2b423f21fec3419eba35efebd