From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1A8491FF15C for ; Wed, 30 Oct 2024 12:28:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B1ADE1666D; Wed, 30 Oct 2024 12:28:26 +0100 (CET) Date: Wed, 30 Oct 2024 12:28:22 +0100 (CET) From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= To: Maximiliano Sandoval , pmg-devel@lists.proxmox.com Message-ID: <1419348031.5069.1730287702708@webmail.proxmox.com> In-Reply-To: <20241030104558.133410-1-m.sandoval@proxmox.com> References: <20241030104558.133410-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev69 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH pmg-api] api: document that SSL fingerprints are SHA-256 X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" > Maximiliano Sandoval hat am 30.10.2024 11:45 CET geschrieben: > > > Signed-off-by: Maximiliano Sandoval > --- > > The regex pattern bellow matches the lenght (64 characters plus colons) of a > SHA-256 fingerprint. and there is a standard option for it in PVE::JSONSchema that should be used instead ;) it has one slight difference, but that can be accounted here easily if needed (it allows lower case hex characters as well as upper case). > > src/PMG/API2/Cluster.pm | 2 +- > src/PMG/CLI/pmgcm.pm | 2 +- > src/PMG/ClusterConfig.pm | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/PMG/API2/Cluster.pm b/src/PMG/API2/Cluster.pm > index 84dafabb..df5df949 100644 > --- a/src/PMG/API2/Cluster.pm > +++ b/src/PMG/API2/Cluster.pm > @@ -409,7 +409,7 @@ __PACKAGE__->register_method({ > type => 'string', format => 'ip', > }, > fingerprint => { > - description => "SSL certificate fingerprint.", > + description => "SSL certificate SHA-256 fingerprint.", > type => 'string', > pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$', > }, > diff --git a/src/PMG/CLI/pmgcm.pm b/src/PMG/CLI/pmgcm.pm > index ecf9cc76..a2d46910 100644 > --- a/src/PMG/CLI/pmgcm.pm > +++ b/src/PMG/CLI/pmgcm.pm > @@ -167,7 +167,7 @@ __PACKAGE__->register_method({ > type => 'string', format => 'ip', > }, > fingerprint => { > - description => "SSL certificate fingerprint.", > + description => "SSL certificate SHA-256 fingerprint.", > type => 'string', > pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$', > optional => 1, > diff --git a/src/PMG/ClusterConfig.pm b/src/PMG/ClusterConfig.pm > index c52508dc..2ca1b104 100644 > --- a/src/PMG/ClusterConfig.pm > +++ b/src/PMG/ClusterConfig.pm > @@ -73,7 +73,7 @@ sub properties { > pattern => valid_ssh_pubkey_regex(), > }, > fingerprint => { > - description => "SSL certificate fingerprint.", > + description => "SSL certificate SHA-256 fingerprint.", > type => 'string', > pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$', > }, > -- > 2.39.5 > > > > _______________________________________________ > pmg-devel mailing list > pmg-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel