From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2287760E94 for ; Wed, 18 Nov 2020 19:34:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 145301E772 for ; Wed, 18 Nov 2020 19:34:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 630831E765 for ; Wed, 18 Nov 2020 19:34:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2B835439A1 for ; Wed, 18 Nov 2020 19:34:29 +0100 (CET) Date: Wed, 18 Nov 2020 19:34:23 +0100 (CET) From: Dietmar Maurer To: Stoiko Ivanov , pmg-devel@lists.proxmox.com Message-ID: <1392664598.271.1605724464296@webmail.proxmox.com> In-Reply-To: <20201118175935.11516-2-s.ivanov@proxmox.com> References: <20201118175935.11516-1-s.ivanov@proxmox.com> <20201118175935.11516-2-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.4-Rev13 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.118 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [job.pm] Subject: Re: [pmg-devel] [PATCH pmg-api 1/2] pbs: api: add statistic parameter to run_backup X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Nov 2020 18:34:30 -0000 why does this default => 1 ? Statistics are large, and not really required for fully functional restore. IMHO, I want backups as small as possible. > On 11/18/2020 6:59 PM Stoiko Ivanov wrote: > > > Without it the backup does not include the statistics database > > Reported-by: Martin Maurer > Signed-off-by: Stoiko Ivanov > --- > src/PMG/API2/PBS/Job.pm | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/src/PMG/API2/PBS/Job.pm b/src/PMG/API2/PBS/Job.pm > index 793ad88..a0d942a 100644 > --- a/src/PMG/API2/PBS/Job.pm > +++ b/src/PMG/API2/PBS/Job.pm > @@ -266,6 +266,12 @@ __PACKAGE__->register_method ({ > description => "Proxmox Backup Server ID.", > type => 'string', format => 'pve-configid', > }, > + statistic => { > + description => "Backup statistic databases.", > + type => 'boolean', > + optional => 1, > + default => 1, > + }, > }, > }, > returns => { type => "string" }, > @@ -284,6 +290,8 @@ __PACKAGE__->register_method ({ > die "PBS remote '$remote' does not exist\n" if !$remote_config; > die "PBS remote '$remote' is disabled\n" if $remote_config->{disable}; > > + $param->{statistic} //= 1; > + > my $pbs = PVE::PBSClient->new($remote_config, $remote, $conf->{secret_dir}); > my $backup_dir = "/var/lib/pmg/backup/current"; > > -- > 2.20.1 > > > > _______________________________________________ > pmg-devel mailing list > pmg-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel