From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmg-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 686C21FF191
	for <inbox@lore.proxmox.com>; Fri, 21 Feb 2025 13:46:29 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 06A8CFDD;
	Fri, 21 Feb 2025 13:46:29 +0100 (CET)
Date: Fri, 21 Feb 2025 13:45:55 +0100 (CET)
From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
To: Markus Frank <m.frank@proxmox.com>, pmg-devel@lists.proxmox.com
Message-ID: <1206226125.10150.1740141955656@webmail.proxmox.com>
In-Reply-To: <20250218161905.17224-11-m.frank@proxmox.com>
References: <20250218161905.17224-1-m.frank@proxmox.com>
 <20250218161905.17224-11-m.frank@proxmox.com>
MIME-Version: 1.0
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev73
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.045 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [proxmox.com]
Subject: Re: [pmg-devel] [PATCH pmg-gui v5 10/10] add panel for realms to
 User Management
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
 <pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, 
 <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pmg-devel-bounces@lists.proxmox.com
Sender: "pmg-devel" <pmg-devel-bounces@lists.proxmox.com>


> Markus Frank <m.frank@proxmox.com> hat am 18.02.2025 17:19 CET geschrieben:
> 
>  
> Make the realm configuration available in PMG and disable LDAP/AD
> realms for now and use the name oidc instead of openid.
> 
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
>  js/UserManagement.js |  6 ++++++
>  js/Utils.js          | 23 +++++++++++++++++++++++
>  2 files changed, 29 insertions(+)
> 
> diff --git a/js/UserManagement.js b/js/UserManagement.js
> index 65fabbf..54493b1 100644
> --- a/js/UserManagement.js
> +++ b/js/UserManagement.js
> @@ -34,5 +34,11 @@ Ext.define('PMG.UserManagement', {
>  	    itemId: 'pop',
>  	    iconCls: 'fa fa-reply-all',
>  	},
> +	{
> +	    xtype: 'pmxAuthView',
> +	    title: gettext('Realms'),
> +	    itemId: 'domains',
> +	    iconCls: 'fa fa-address-book-o',
> +	},
>      ],
>  });
> diff --git a/js/Utils.js b/js/Utils.js
> index 9b5f054..055b938 100644
> --- a/js/Utils.js
> +++ b/js/Utils.js
> @@ -851,6 +851,29 @@ Ext.define('PMG.Utils', {
>      constructor: function() {
>  	var me = this;
>  
> +	// use oidc instead of openid
> +	Proxmox.Schema.authDomains.oidc = Proxmox.Schema.authDomains.openid;
> +	Proxmox.Schema.authDomains.oidc.useTypeInUrl = false;
> +	delete Proxmox.Schema.authDomains.openid;

unless we want to rename it to oidc everywhere, this makes me think that it's not a good idea to deviate from the existing naming scheme in PMG?

> +
> +	// Disable LDAP/AD as a realm until LDAP/AD login is implemented
> +	Proxmox.Schema.authDomains.ldap.add = false;
> +	Proxmox.Schema.authDomains.ad.add = false;
> +
> +	Proxmox.Schema.authDomains.pmg = {
> +	    add: false,
> +	    edit: false,
> +	    pwchange: false,
> +	    sync: false,
> +	};
> +
> +	Proxmox.Schema.authDomains.pam = {
> +	    add: false,
> +	    edit: false,
> +	    pwchange: false,
> +	    sync: false,
> +	};
> +
>  	// do whatever you want here
>  	Proxmox.Utils.override_task_descriptions({
>  	    applycustomscores: ['', gettext('Apply custom SpamAssassin scores')],
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel