From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7F87F690AE for ; Wed, 10 Mar 2021 13:28:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6B3AE1CC67 for ; Wed, 10 Mar 2021 13:27:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B90C31CC57 for ; Wed, 10 Mar 2021 13:27:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 82D9946141 for ; Wed, 10 Mar 2021 13:27:34 +0100 (CET) To: pmg-devel@lists.proxmox.com References: <20210309141401.19237-1-w.bumiller@proxmox.com> From: Dominik Csapak Message-ID: <117f1bea-86d1-c855-0dd0-887beeaf5a55@proxmox.com> Date: Wed, 10 Mar 2021 13:27:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210309141401.19237-1-w.bumiller@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.194 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pmg-devel] [RFC api/gui/wtk/acme 0/many] Certificates & ACME X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Mar 2021 12:28:06 -0000 so i tested this a bit, and mostly works as advertised (will look a bit deeper into the code today/tomorrow) i tested with a local 'pebble' instance and for dns i used a local powerdns instance a few small problems (some we already discussed off-list): * proxmox-acme-rs/client could use a 'Content-Length' header (necessary for pebble acme server, seems other acme endpoints are not as strict) * the 'Add ACME Account' Button in the cert panel does not work * cannot delete accounts that do not exist on the ACME server anymore (triggered this by restarting the pebble instance, it does not save anything persistent) * for the selection of API/SMTP i would have rather expected checkboxes, it was not immediately clear that it is a multi- select combobox (though i think thomas nudged you in that direction?), but it's not too bad * the dns plugin window behaves strangely: when editing a field on a plugin where we have the schema, the form does not get dirty, only when changing another field though it is entirely possible that this behaviour was already there otherwise LGTM On 3/9/21 3:13 PM, Wolfgang Bumiller wrote: > These are the pmg-api, pmg-gui and proxmox-widget-toolkit and > proxmox-acme parts of the ACME series for PMG. > > This requires `pmg-rs` package, which replaces the ACME client from > `proxmox-acme` and provides the CSR generation and is written in rust. > Note that the DNS challenge handling still uses proxmox-acme for now. > > proxmox-acme: > * Just a `use` statement fixup > * Still used for the DNS challenge > > pmg-gui: > Just adds the "certificate view", but the real dirt lives in the > widget-toolkit. > > proxmox-widget-toolkits: > Gets the Certificate, ACME Account, ACME Plugin and ACME Domain view > from PVE adapted to be usable for PMG. > Changes to PVE are mainly: > * API URLs need to be provided since they differ a bit between PVE > and PMG. > * some additional buttons/fields specific to pmg generated if the > parameters for them are present > > pmg-api: > Simply gets API entry points for the above. These too are mostly > copied from PVE and adapted (also the ACME client API from pmg-rs is slightly > different/cleaned up, so that's a minor incompatiblity in some > otherwise common code, but a `pve-rs` may fix that). But some things > could definitely already go to pve-common (especially schema stuff). > > Note that while I did add the corresponding files to the cluster sync, > this still needs testing *and* issuing an API certificate may break > cluster functionality currently. (Stoiko is working on that) > > > _______________________________________________ > pmg-devel mailing list > pmg-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel > >