From: Markus Frank <m.frank@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH widget-toolkit v6 09/12] fix: panel: AuthView: change API path in pmx-domains model
Date: Tue, 25 Feb 2025 18:33:36 +0100 [thread overview]
Message-ID: <112fa77e-7ec2-4d37-9e59-13d68322d14f@proxmox.com> (raw)
In-Reply-To: <20250225133619.42012-10-m.frank@proxmox.com>
This patch breaks pbs WebUI. I will send a fix tomorrow.
On 2025-02-25 14:36, Markus Frank wrote:
> Currently it always uses the default path because it was hardcoded into
> the 'pmx-domains' model.
>
> Fixes: 8d4faa88212757f274cc177c906af09d4ebe07bb
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> Co-authored-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> This patch is new to v6. Required to change the API path to
> /access/auth-realm
>
> src/panel/AuthView.js | 20 ++++++++++++--------
> 1 file changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/src/panel/AuthView.js b/src/panel/AuthView.js
> index f607532..0e1718e 100644
> --- a/src/panel/AuthView.js
> +++ b/src/panel/AuthView.js
> @@ -47,14 +47,6 @@ Ext.define('Proxmox.panel.AuthView', {
> },
> ],
>
> - store: {
> - model: 'pmx-domains',
> - sorters: {
> - property: 'realm',
> - direction: 'ASC',
> - },
> - },
> -
> openEditWindow: function(authType, realm) {
> let me = this;
> const { useTypeInUrl, onlineHelp } = Proxmox.Schema.authDomains[authType];
> @@ -111,6 +103,18 @@ Ext.define('Proxmox.panel.AuthView', {
> initComponent: function() {
> var me = this;
>
> + me.store = {
> + model: 'pmx-domains',
> + sorters: {
> + property: 'realm',
> + direction: 'ASC',
> + },
> + proxy: {
> + type: 'proxmox',
> + url: `/api2/json${me.baseUrl}`,
> + },
> + };
> +
> let menuitems = [];
> for (const [authType, config] of Object.entries(Proxmox.Schema.authDomains).sort()) {
> if (!config.add) { continue; }
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next prev parent reply other threads:[~2025-02-25 17:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 13:36 [pmg-devel] [PATCH pve-common/perl-rs/pmg-api/widget-toolkit/pmg-gui v6 0/12] fix #3892: OpenID Connect Markus Frank
2025-02-25 13:36 ` [pmg-devel] [PATCH pve-common v6 1/12] add Schema package with auth module that contains realm sync options Markus Frank
2025-02-25 17:24 ` Thomas Lamprecht
2025-02-25 13:36 ` [pmg-devel] [PATCH proxmox-perl-rs v6 2/12] move openid code from pve-rs to common Markus Frank
2025-02-25 13:36 ` [pmg-devel] [PATCH proxmox-perl-rs v6 3/12] remove empty PMG::RS::OpenId package to avoid confusion Markus Frank
2025-02-25 13:36 ` [pmg-devel] [PATCH pmg-api v6 4/12] config: add plugin system for authentication realms Markus Frank
2025-02-25 16:32 ` Stoiko Ivanov
2025-02-25 13:36 ` [pmg-devel] [PATCH pmg-api v6 5/12] config: add oidc type authentication realm Markus Frank
2025-02-26 10:20 ` Mira Limbeck
2025-02-25 13:36 ` [pmg-devel] [PATCH pmg-api v6 6/12] api: add/update/remove authentication realms like in PVE Markus Frank
2025-02-25 13:36 ` [pmg-devel] [PATCH pmg-api v6 7/12] api: oidc login similar to PVE Markus Frank
2025-02-25 13:36 ` [pmg-devel] [PATCH widget-toolkit v6 08/12] fix: window: AuthEditBase: rename variable 'realm' to 'type' Markus Frank
2025-02-25 13:36 ` [pmg-devel] [PATCH widget-toolkit v6 09/12] fix: panel: AuthView: change API path in pmx-domains model Markus Frank
2025-02-25 17:33 ` Markus Frank [this message]
2025-02-25 13:36 ` [pmg-devel] [PATCH widget-toolkit v6 10/12] form: RealmComboBox: add option to change the API path Markus Frank
2025-02-25 13:36 ` [pmg-devel] [PATCH pmg-gui v6 11/12] login: add option to login with OIDC realm Markus Frank
2025-02-25 13:36 ` [pmg-devel] [PATCH pmg-gui v6 12/12] add realms panel to user management Markus Frank
2025-02-26 11:08 ` [pmg-devel] [PATCH pve-common/perl-rs/pmg-api/widget-toolkit/pmg-gui v6 0/12] fix #3892: OpenID Connect Mira Limbeck
2025-02-26 11:30 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=112fa77e-7ec2-4d37-9e59-13d68322d14f@proxmox.com \
--to=m.frank@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox