From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0EE457BB64 for ; Wed, 13 Jul 2022 08:58:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F085E2DFC4 for ; Wed, 13 Jul 2022 08:58:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 13 Jul 2022 08:58:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1CBFA41C7A for ; Wed, 13 Jul 2022 08:58:02 +0200 (CEST) Message-ID: <025f66c8-3715-4a26-aea9-240ad82b102f@proxmox.com> Date: Wed, 13 Jul 2022 08:58:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:103.0) Gecko/20100101 Thunderbird/103.0 To: Stoiko Ivanov , pmg-devel@lists.proxmox.com References: <20220712121428.23851-1-s.ivanov@proxmox.com> Content-Language: en-GB From: Thomas Lamprecht In-Reply-To: <20220712121428.23851-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pmg-devel] [PATCH pmg-api] pmg-daily: avoid short-circuting update of local channels X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 06:58:34 -0000 Am 12/07/2022 um 14:14 schrieb Stoiko Ivanov: > by using ||= directly with the actual update call as operand, it does > not get run, if `sa-update` already returned that a restart is needed. > > reported in our community forum: > https://forum.proxmox.com/threads/.112112/ > > Signed-off-by: Stoiko Ivanov > --- > src/bin/pmg-daily | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/bin/pmg-daily b/src/bin/pmg-daily > index b06515c..a9bfd1c 100755 > --- a/src/bin/pmg-daily > +++ b/src/bin/pmg-daily > @@ -85,7 +85,8 @@ if (system('sa-update') == 0) { > } > > eval { > - $restart_filter ||= PMG::Utils::update_local_spamassassin_channels(0); > + my $res ||= PMG::Utils::update_local_spamassassin_channels(0); ||= makes not much sense for a newly declared variable, just use plain assignment please. Alternatively you could also just do: $restart_filter = 1 if PMG::Utils::update_local_spamassassin_channels(0); > + $restart_filter ||= $res; > }; > syslog('err', "$@") if $@; >