From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 116121FF189
	for <inbox@lore.proxmox.com>; Thu,  4 Sep 2025 14:31:26 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 9A9672E575;
	Thu,  4 Sep 2025 14:31:41 +0200 (CEST)
Date: Thu, 4 Sep 2025 14:31:38 +0200
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>
Message-ID: <t4mdhf6a3xgladqtzablkffa5egips47s6fq3y4ateh6q5w5db@7gnxfglgjfdw>
References: <20250904081900.12655-1-s.hanreich@proxmox.com>
 <20250904081900.12655-5-s.hanreich@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20250904081900.12655-5-s.hanreich@proxmox.com>
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1756989082479
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.075 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pdm-devel] appled: [PATCH pve-network v4 1/6] sdn: api: return
 null for rollback / lock endpoints
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
 <pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>, 
 <mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>, 
 <mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
 <pdm-devel@lists.proxmox.com>
Cc: pdm-devel@lists.proxmox.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>

applied all pve-network patches, thanks

On Thu, Sep 04, 2025 at 10:18:29AM +0200, Stefan Hanreich wrote:
> lock_sdn_config can return a boolean value, which will then in turn
> get returned as data from the API calls. Since we hint type null here,
> this leads to problems with the pve-api-client in rust. Fix the return
> value for this API call by adding an explicit return statement.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>  src/PVE/API2/Network/SDN.pm | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/PVE/API2/Network/SDN.pm b/src/PVE/API2/Network/SDN.pm
> index af00b1a..88b229c 100644
> --- a/src/PVE/API2/Network/SDN.pm
> +++ b/src/PVE/API2/Network/SDN.pm
> @@ -192,6 +192,8 @@ __PACKAGE__->register_method({
>                  $param->{'lock-token'},
>              );
>          }
> +
> +        return;
>      },
>  });
>  
> @@ -247,6 +249,8 @@ __PACKAGE__->register_method({
>          PVE::Network::SDN::lock_sdn_config(
>              $rollback, "could not rollback SDN configuration", $lock_token,
>          );
> +
> +        return;
>      },
>  });
>  
> -- 
> 2.47.2


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel