From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5DE241FF13B for ; Wed, 28 Jan 2026 10:26:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F3FF1D31B; Wed, 28 Jan 2026 10:26:45 +0100 (CET) Date: Wed, 28 Jan 2026 10:26:11 +0100 From: Gabriel Goller To: Lukas Wagner Message-ID: Mail-Followup-To: Lukas Wagner , Proxmox Datacenter Manager development discussion , Shan Shaji References: <20260123172910.244121-1-s.shaji@proxmox.com> <20260123172910.244121-3-s.shaji@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20241002-35-39f9a6 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1769592305936 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pdm-devel] [PATCH datacenter-manager 2/3] fix #7179: cli: admin: expose acme commands X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" [...] > [...] > > > diff --git a/cli/admin/src/main.rs b/cli/admin/src/main.rs > > index bcaa0a6..15114c9 100644 > > --- a/cli/admin/src/main.rs > > +++ b/cli/admin/src/main.rs > > @@ -9,6 +9,7 @@ use proxmox_router::RpcEnvironment; > > use proxmox_schema::api; > > use proxmox_sys::fs::CreateOptions; > > > > +mod acme; > > mod remotes; > > mod support_status; > > > > @@ -21,13 +22,17 @@ async fn run() -> Result<(), Error> { > > &pdm_api_types::AccessControlConfig, > > pdm_buildcfg::configdir!("/access"), > > )?; > > + proxmox_acme_api::init(pdm_buildcfg::configdir!("/acme"), false)?; > > + > > proxmox_log::Logger::from_env("PDM_LOG", proxmox_log::LevelFilter::INFO) > > + .stderr_on_no_workertask() > > .stderr() > > .init()?; > > Doing this actually prints all messages logged outside a workertask > *twice*, since this adds two subscribers that will print to stdout. > > I think it would make more sense to: > > proxmox_log::Logger::from_env("PDM_LOG", proxmox_log::LevelFilter::INFO) > .tasklog_pbs() > .stderr() > .init()?; > > ... which should print *all* messages to stderr and messages from within > a task log will also be stored in the task log. > > Maybe also ask Gabriel about these, he did a lot of work on logging. > > @Gabriel, would my proposal make sense here? Yep, looks good! We can also deprecate `tasklog_pbs` in favor of a more generic `tasklog` function. This change is ok because pve's tasklog implementation is quite different from pbs, so we won't use this for pve workers anytime soon. > > > > server::context::init()?; > > > > let cmd_def = CliCommandMap::new() > > + .insert("acme", acme::acme_mgmt_cli()) > > .insert("remote", remotes::cli()) > > .insert( > > "report", > _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel