From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 40C801FF138 for ; Wed, 04 Mar 2026 09:31:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5502B2CB2; Wed, 4 Mar 2026 09:32:38 +0100 (CET) From: Maximiliano Sandoval To: Dominik Rusovac Subject: Re: [PATCH datacenter-manager] ui: adjust testing description In-Reply-To: <20260304070422.17185-1-d.rusovac@proxmox.com> (Dominik Rusovac's message of "Wed, 4 Mar 2026 08:04:22 +0100") References: <20260304070422.17185-1-d.rusovac@proxmox.com> User-Agent: mu4e 1.12.9; emacs 30.1 Date: Wed, 04 Mar 2026 09:32:32 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772613127249 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.588 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NUMERIC_HTTP_ADDR 1.242 Uses a numeric IP address in URL RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.668 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.322 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1.141 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record WEIRD_PORT 0.001 Uses non-standard port number for HTTP Message-ID-Hash: BQKQ26JQ5MC22SEKCFDM4UUDL32WWZLF X-Message-ID-Hash: BQKQ26JQ5MC22SEKCFDM4UUDL32WWZLF X-MailFrom: m.sandoval@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pdm-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Dominik Rusovac writes: > Describe how to use trunk server for testing. > > Signed-off-by: Dominik Rusovac > --- > ui/README.md | 18 +++++------------- > 1 file changed, 5 insertions(+), 13 deletions(-) > > diff --git a/ui/README.md b/ui/README.md > index f083ea5..05d8ae6 100644 > --- a/ui/README.md > +++ b/ui/README.md > @@ -2,20 +2,12 @@ > > # Testing > > -1.) start datacenter manager > +Assuming pdm is running on, for example, 172.16.254.1:8443. I would say this is a missing an "at" before the address. > -sudo ./target/debug/proxmox-datacenter-privileged-api > -sudo -u www-data ./target/debug/proxmox-datacenter-api > +To test on http://localhost:8080, use: > > -2.) either: start local trunk server > + trunk serve --proxy-backend=https://172.16.254.1:8443/api2/ --proxy-insecure > > - trunk serve --proxy-backend=https://localhost:8443/api2/ --proxy-insecure > +To test elsewhere, say https://dev:8080/, generate a cert to obtain `api.key` and `api.pem`, and use: > > - then test with url: http://localhost:8080 > - > -2.) or: copy files into pdm js folder: > - > - make all > - make install > - > -And test with url https://localhost:8443 > + trunk serve --address 0.0.0.0 --serve-base / --proxy-backend https://172.16.254.1:8443/api2/ --public-url https://dev:8080/ --proxy-insecure --tls-key-path api.key --tls-cert-path api.pem This is an improvement compared to the current state. As a side note, I would like to see an introduction with a high-level description of the process, something along the lines of "For testing changes in the web UI, we recommend to run a Datacenter Manager daemon, which can be done on a virtual machine or an existing instance, build the web UI with your changes and proxy the API calls to the previously mentioned daemon, this can be done via...". -- Maximiliano