From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 904C71FF17C
for <inbox@lore.proxmox.com>; Wed, 16 Apr 2025 10:24:11 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id F3F08301F5;
Wed, 16 Apr 2025 10:24:09 +0200 (CEST)
Date: Wed, 16 Apr 2025 10:24:07 +0200
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Message-ID: <iw5vtbm77pjhsksuo6k35qmbuuu2bmhavhdhetzpoau2rufuwj@mbzvdcmnp4jo>
References: <20250416074054.719381-1-d.csapak@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20250416074054.719381-1-d.csapak@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.081 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pdm-devel] applied: [PATCH yew-comp] derive more standard traits
for several types
X-BeenThere: pdm-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
<pdm-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pdm-devel/>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel>,
<mailto:pdm-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Cc: pdm-devel@lists.proxmox.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pdm-devel-bounces@lists.proxmox.com
Sender: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>
applied, thanks
On Wed, Apr 16, 2025 at 09:40:54AM +0200, Dominik Csapak wrote:
> this is sensible to have, e.g. when we want to have them as part of a
> type for a store
>
> Suggested-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> this replaces the patch
> https://lore.proxmox.com/pbs-devel/20250416070703.493585-1-d.csapak@proxmox.com/
>
> from this series:
> https://lore.proxmox.com/pdm-devel/20250411140520.1475644-1-d.csapak@proxmox.com/
>
> the rest of the series can still be used when this is applied and
> proxmox-yew-comp is bumped
>
> src/common_api_types.rs | 2 +-
> src/journal_view.rs | 2 +-
> src/proxmox_product.rs | 2 +-
> src/status.rs | 4 ++++
> 4 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/src/common_api_types.rs b/src/common_api_types.rs
> index 58aec58..a14095f 100644
> --- a/src/common_api_types.rs
> +++ b/src/common_api_types.rs
> @@ -66,7 +66,7 @@ impl ExtractPrimaryKey for TaskListItem {
> }
>
> /// Clasify task status.
> -#[derive(Copy, Clone, PartialEq)]
> +#[derive(Clone, Copy, Debug, Eq, PartialEq, Hash)]
> pub enum TaskStatusClass {
> Ok,
> Warning,
> diff --git a/src/journal_view.rs b/src/journal_view.rs
> index ae050eb..077e9bd 100644
> --- a/src/journal_view.rs
> +++ b/src/journal_view.rs
> @@ -75,7 +75,7 @@ enum JournalRequest {
> Top(usize, String),
> }
>
> -#[derive(PartialEq, Clone, Copy)]
> +#[derive(Clone, Copy, Debug, Eq, PartialEq, Hash)]
> pub enum Position {
> Initial,
> Bottom,
> diff --git a/src/proxmox_product.rs b/src/proxmox_product.rs
> index 2ca0577..0e81cc8 100644
> --- a/src/proxmox_product.rs
> +++ b/src/proxmox_product.rs
> @@ -23,7 +23,7 @@ pub trait ProjectInfo {
> }
>
> /// Enumerate the different Proxmox products.
> -#[derive(PartialEq, Debug, Copy, Clone)]
> +#[derive(Clone, Copy, Debug, Eq, PartialEq, Hash)]
> pub enum ExistingProduct {
> PVE,
> PMG,
> diff --git a/src/status.rs b/src/status.rs
> index 9d951c5..a2866d1 100644
> --- a/src/status.rs
> +++ b/src/status.rs
> @@ -7,6 +7,7 @@ use pwt::{
>
> /// Used to represent a Status of some resource or component, e.g.
> /// if a PVE node is online or not.
> +#[derive(Clone, Copy, Debug, Eq, PartialEq, Hash)]
> pub enum Status {
> Success,
> Warning,
> @@ -27,6 +28,7 @@ impl Status {
> }
>
> /// Used to represent the state of a Node, being PVE or PBS
> +#[derive(Clone, Copy, Debug, Eq, PartialEq, Hash)]
> pub enum NodeState {
> Online,
> Offline,
> @@ -45,6 +47,7 @@ impl NodeState {
> }
>
> /// Used to represent the state of a PVE guest, such as a VM
> +#[derive(Clone, Copy, Debug, Eq, PartialEq, Hash)]
> pub enum GuestState {
> Running,
> Paused,
> @@ -67,6 +70,7 @@ impl GuestState {
> }
>
> /// Used to represent the state of a Storage or Datastore
> +#[derive(Clone, Copy, Debug, Eq, PartialEq, Hash)]
> pub enum StorageState {
> Available,
> Unavailable,
> --
> 2.39.5
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel