From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 94D931FF189 for ; Thu, 4 Sep 2025 14:47:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A748C2EF9B; Thu, 4 Sep 2025 14:47:28 +0200 (CEST) Date: Thu, 4 Sep 2025 14:46:55 +0200 From: Wolfgang Bumiller To: Stefan Hanreich Message-ID: References: <20250904081900.12655-1-s.hanreich@proxmox.com> <20250904081900.12655-4-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250904081900.12655-4-s.hanreich@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756989998970 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.073 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] applied: [PATCH proxmox-backup v4 1/1] api: change integer schema parameters to i64 X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: pdm-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" applied, thanks On Thu, Sep 04, 2025 at 10:18:28AM +0200, Stefan Hanreich wrote: > The type for the minimum / maximum / default values for integer > schemas has changed to i64 (from isize). Fix all call sites that are > converting to isize to convert to i64 instead. > > Signed-off-by: Stefan Hanreich > --- > pbs-tape/src/bin/pmt.rs | 6 +++--- > proxmox-backup-client/src/main.rs | 2 +- > pxar-bin/src/main.rs | 6 +++--- > src/api2/backup/upload_chunk.rs | 15 ++++++--------- > 4 files changed, 13 insertions(+), 16 deletions(-) > > diff --git a/pbs-tape/src/bin/pmt.rs b/pbs-tape/src/bin/pmt.rs > index d70c61e9..77b61314 100644 > --- a/pbs-tape/src/bin/pmt.rs > +++ b/pbs-tape/src/bin/pmt.rs > @@ -28,17 +28,17 @@ use pbs_tape::{ > > pub const FILE_MARK_COUNT_SCHEMA: Schema = IntegerSchema::new("File mark count.") > .minimum(1) > - .maximum(i32::MAX as isize) > + .maximum(i32::MAX as i64) > .schema(); > > pub const FILE_MARK_POSITION_SCHEMA: Schema = IntegerSchema::new("File mark position (0 is BOT).") > .minimum(0) > - .maximum(i32::MAX as isize) > + .maximum(i32::MAX as i64) > .schema(); > > pub const RECORD_COUNT_SCHEMA: Schema = IntegerSchema::new("Record count.") > .minimum(1) > - .maximum(i32::MAX as isize) > + .maximum(i32::MAX as i64) > .schema(); > > pub const DRIVE_OPTION_SCHEMA: Schema = > diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs > index 3f6c5adb..7dc2c486 100644 > --- a/proxmox-backup-client/src/main.rs > +++ b/proxmox-backup-client/src/main.rs > @@ -726,7 +726,7 @@ fn spawn_catalog_upload( > type: Integer, > description: "Max number of entries to hold in memory.", > optional: true, > - default: pbs_client::pxar::ENCODER_MAX_ENTRIES as isize, > + default: pbs_client::pxar::ENCODER_MAX_ENTRIES as i64, > }, > "dry-run": { > type: Boolean, > diff --git a/pxar-bin/src/main.rs b/pxar-bin/src/main.rs > index cccbb331..cba5646b 100644 > --- a/pxar-bin/src/main.rs > +++ b/pxar-bin/src/main.rs > @@ -330,9 +330,9 @@ fn extract_archive( > "entries-max": { > description: "Max number of entries loaded at once into memory", > optional: true, > - default: ENCODER_MAX_ENTRIES as isize, > + default: ENCODER_MAX_ENTRIES as i64, > minimum: 0, > - maximum: isize::MAX, > + maximum: i64::MAX, > }, > "payload-output": { > description: "'ppxar' payload output data file to create split archive.", > @@ -354,7 +354,7 @@ async fn create_archive( > no_fifos: bool, > no_sockets: bool, > exclude: Option>, > - entries_max: isize, > + entries_max: i64, > payload_output: Option, > ) -> Result<(), Error> { > let patterns = { > diff --git a/src/api2/backup/upload_chunk.rs b/src/api2/backup/upload_chunk.rs > index f8b7ecbd..8dd7e4d5 100644 > --- a/src/api2/backup/upload_chunk.rs > +++ b/src/api2/backup/upload_chunk.rs > @@ -134,10 +134,9 @@ pub const API_METHOD_UPLOAD_FIXED_CHUNK: ApiMethod = ApiMethod::new( > "encoded-size", > false, > &IntegerSchema::new("Encoded chunk size.") > - .minimum((std::mem::size_of::() as isize) + 1) > + .minimum((std::mem::size_of::() as i64) + 1) > .maximum( > - 1024 * 1024 * 16 > - + (std::mem::size_of::() as isize) > + 1024 * 1024 * 16 + (std::mem::size_of::() as i64) > ) > .schema() > ), > @@ -197,10 +196,9 @@ pub const API_METHOD_UPLOAD_DYNAMIC_CHUNK: ApiMethod = ApiMethod::new( > "encoded-size", > false, > &IntegerSchema::new("Encoded chunk size.") > - .minimum((std::mem::size_of::() as isize) + 1) > + .minimum((std::mem::size_of::() as i64) + 1) > .maximum( > - 1024 * 1024 * 16 > - + (std::mem::size_of::() as isize) > + 1024 * 1024 * 16 + (std::mem::size_of::() as i64) > ) > .schema() > ), > @@ -357,10 +355,9 @@ pub const API_METHOD_UPLOAD_BLOB: ApiMethod = ApiMethod::new( > "encoded-size", > false, > &IntegerSchema::new("Encoded blob size.") > - .minimum(std::mem::size_of::() as isize) > + .minimum(std::mem::size_of::() as i64) > .maximum( > - 1024 * 1024 * 16 > - + (std::mem::size_of::() as isize) > + 1024 * 1024 * 16 + (std::mem::size_of::() as i64) > ) > .schema() > ) > -- > 2.47.2 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel